Bug 1202554

Summary: PyGIDeprecationWarning: GObject.MainLoop is deprecated; use GLib.MainLoop instead
Product: [Fedora] Fedora Reporter: Paul W. Frields <pfrields>
Component: python-slipAssignee: Nils Philippsen <nphilipp>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 22CC: jpopelka, jrm16020, nphilipp, twoerner, zach
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 0.6.3-1.fc21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-08-26 04:33:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Prefer GLib instead of GObject for wrapper functions none

Description Paul W. Frields 2015-03-16 21:19:57 UTC
firewall-0.3.13-3.fc22 -- When I try to use bash completion for firewall-cmd, I get multiple warnings from the pygobject3 stack. Not sure whether these are due to something on firewalld side, or pygobject3.

Comment 1 Paul W. Frields 2015-03-16 21:21:08 UTC
Warnings received when entering 'firewall-cmd --<TAB>':

/usr/lib/python2.7/site-packages/slip/_wrappers/_gobject.py:53: PyGIDeprecationWarning: GObject.MainLoop is deprecated; use GLib.MainLoop instead
  setattr(_self, what, getattr(_mod, what))
/usr/lib/python2.7/site-packages/slip/_wrappers/_gobject.py:53: PyGIDeprecationWarning: GObject.source_remove is deprecated; use GLib.source_remove instead
  setattr(_self, what, getattr(_mod, what))
/usr/lib/python2.7/site-packages/slip/_wrappers/_gobject.py:53: PyGIDeprecationWarning: GObject.timeout_add is deprecated; use GLib.timeout_add instead
  setattr(_self, what, getattr(_mod, what))

Comment 2 Jiri Popelka 2015-03-17 09:43:04 UTC
Yes, these can be seen also with firewall-cmd and firewall-config

# rpm -qf /usr/lib/python2.7/site-packages/slip/_wrappers/_gobject.py
python-slip-0.6.0-3.fc21.noarch

Comment 3 Paul W. Frields 2015-03-17 19:42:16 UTC
https://git.fedorahosted.org/cgit/python-slip.git/commit/?id=7145f0e360b4854d58d95ddb8156184eaf0e885e

I think this is the commit that takes care of the issue. I couldn't yet build a test F22 package because of the Python 3 issues in the spec file due, this may help:

https://fedoraproject.org/w/index.php?title=PackagingDrafts%3APython&diff=403829&oldid=403815

Comment 4 Jiri Popelka 2015-03-24 08:36:49 UTC
*** Bug 1204887 has been marked as a duplicate of this bug. ***

Comment 5 Paul W. Frields 2015-03-26 17:34:11 UTC
Created attachment 1006922 [details]
Prefer GLib instead of GObject for wrapper functions

This patch applies cleanly to upstream master as of today.

Comment 6 Nils Philippsen 2015-08-13 14:48:44 UTC
applied upstream with some slight changes:

commit 72541ae95eb8961584876320edd8e22d5ffa309d
Author:     Paul W. Frields <pfrields>
AuthorDate: Thu Mar 26 13:34:11 2015 -0400
Commit:     Nils Philippsen <nils>
CommitDate: Thu Aug 13 16:22:40 2015 +0200

    use GLib instead of GObject for wrapper functions (#1202554)

https://github.com/nphilipp/python-slip/commit/72541ae95eb8961584876320edd8e22d5ffa309d

Comment 7 Fedora Update System 2015-08-14 15:53:59 UTC
python-slip-0.6.2-1.fc23 has been submitted as an update for Fedora 23.
https://admin.fedoraproject.org/updates/python-slip-0.6.2-1.fc23

Comment 8 Fedora Update System 2015-08-14 15:54:06 UTC
python-slip-0.6.2-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/python-slip-0.6.2-1.fc22

Comment 9 Fedora Update System 2015-08-14 15:56:20 UTC
python-slip-0.6.2-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/python-slip-0.6.2-1.fc21

Comment 10 Fedora Update System 2015-08-17 09:51:21 UTC
python-slip-0.6.3-1.fc23 has been submitted as an update for Fedora 23.
https://admin.fedoraproject.org/updates/python-slip-0.6.3-1.fc23

Comment 11 Fedora Update System 2015-08-17 09:51:31 UTC
python-slip-0.6.3-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/python-slip-0.6.3-1.fc22

Comment 12 Fedora Update System 2015-08-17 09:52:44 UTC
python-slip-0.6.3-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/python-slip-0.6.3-1.fc21

Comment 13 Fedora Update System 2015-08-19 08:04:29 UTC
Package python-slip-0.6.3-1.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing python-slip-0.6.3-1.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-13673/python-slip-0.6.3-1.fc21
then log in and leave karma (feedback).

Comment 14 Zach Villers 2015-08-25 15:00:20 UTC
Hello - I just installed;
Upgraded:
  python-slip.noarch 0.6.3-1.fc23      python-slip-dbus.noarch 0.6.3-1.fc23

and when I run firewall-cmd --reload, i get errors that seem to be related;

sudo firewall-cmd --reload
/usr/lib/python3.4/site-packages/slip/_wrappers/_gobject.py:53: PyGIDeprecationWarning: GObject.MainLoop is deprecated; use GLib.MainLoop instead
  setattr(_self, what, getattr(_mod, what))
/usr/lib/python3.4/site-packages/slip/_wrappers/_gobject.py:53: PyGIDeprecationWarning: GObject.source_remove is deprecated; use GLib.source_remove instead
  setattr(_self, what, getattr(_mod, what))
/usr/lib/python3.4/site-packages/slip/_wrappers/_gobject.py:53: PyGIDeprecationWarning: GObject.timeout_add is deprecated; use GLib.timeout_add instead
  setattr(_self, what, getattr(_mod, what))
success

Comment 15 Fedora Update System 2015-08-26 04:33:28 UTC
python-slip-0.6.3-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2015-09-04 05:19:33 UTC
python-slip-0.6.3-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2015-09-04 11:49:25 UTC
python-slip-0.6.3-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.