Bug 1204033

Summary:	libvirt ignore the --maximum option when use setvcpus only with --maximum
Product:	Red Hat Enterprise Linux 7	Reporter:	Luyao Huang <lhuang>
Component:	libvirt	Assignee:	Pavel Hrdina <phrdina>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	low	Docs Contact:
Priority:	low
Version:	7.1	CC:	dyuan, honzhang, mzhan, phrdina, rbalakri, shyu
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	libvirt-1.2.16-1.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-11-19 06:24:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Luyao Huang 2015-03-20 08:18:42 UTC

Description of problem:
libvirt ignore the --maxmum option when use setvcpus only with --maxmum

Version-Release number of selected component (if applicable):
libvirt-1.2.8-16.el7_1.1.x86_64
qemu-kvm-rhev-2.1.2-23.el7_1.1.x86_64

How reproducible:
100%

Steps to Reproduce:
 
1.prepare a offline vm:
# virsh setvcpus test3 --maximum 10
error: Failed to create controller cpu for group: No such file or directory

2.
# virsh setvcpus test3 --maximum 4 --current
error: --maximum must be used with --config only

3.
# virsh setvcpus test3 --maximum 4 --live
error: --maximum must be used with --config only


Actual results:

setvcpus do a wrong things if just pass maximum.

it is a logic issue in the virsh client

Expected results:

# virsh setvcpus test3 --maximum 10
error: --maximum must be used with --config only


or allow this:
# virsh setvcpus test3 --maximum 10


infomation:
when do setvcpus only with --maximum, libvirt ignore this and continue do virDomainSetVcpus with no flags

Comment 1 Luyao Huang 2015-03-20 08:23:29 UTC

upstream patch:

http://www.redhat.com/archives/libvir-list/2015-March/msg01044.html

Comment 2 Pavel Hrdina 2015-03-20 15:04:39 UTC

Upstream patch proposed:

https://www.redhat.com/archives/libvir-list/2015-March/msg01073.html

Comment 3 Pavel Hrdina 2015-05-04 09:12:08 UTC

Upstream commit:

commit 3dae162db7f53cce57a21ad15799ace27768a8a0
Author: Luyao Huang <lhuang>
Date:   Fri Mar 20 15:39:03 2015 +0100

    tools: fix the wrong check when use virsh setvcpus --maximum
    
    The --maximum option wasn't properly parsed and the equivalent flag
    wasn't set.  Fix this bug and also rewrite the way we check this option
    by using new macro.  The new approach is that --maximum requires
    --config, no other combination is allowed, because they don't make sense.
    
    The new error will be:
    
     # virsh setvcpus test --maximum 10
     error: Option --config is required by option --maximum
    
    Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1204033
    
    Signed-off-by: Luyao Huang <lhuang>
    Signed-off-by: Pavel Hrdina <phrdina>

v1.2.15-7-g3dae162

Comment 5 hongming 2015-08-07 09:45:50 UTC

Verify it as follows. The result is expected. Move its status to VERIFIED.


# rpm -q libvirt
libvirt-1.2.17-3.el7.x86_64

# virsh setvcpus test4 --maximum 10
error: Option --config is required by option --maximum

# virsh destroy test4
Domain test4 destroyed

# virsh setvcpus test4 --maximum 10
error: Option --config is required by option --maximum

# virsh setvcpus test4 --maximum 10 --config

# virsh start test4
Domain test4 started

# virsh dumpxml test4|grep vcpu
  <vcpu placement='static' current='4'>10</vcpu>

Comment 7 errata-xmlrpc 2015-11-19 06:24:40 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2202.html