Bug 120508

Summary: CAN-2004-0421 libpng error reporting has out of bounds memory access
Product: [Fedora] Fedora Reporter: Steve Grubb <linux_4ever>
Component: libpngAssignee: Matthias Clasen <mclasen>
Status: CLOSED DUPLICATE QA Contact:
Severity: high Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-02-21 19:02:30 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch that fixes the problem none

Description Steve Grubb 2004-04-09 17:04:54 UTC 
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.4.2)
Gecko/20040308

Description of problem:
During a code review I found an out of bounds access error in the
pngerror.c file. Line 139 is this:

png_memcpy(buffer+iout, message, 64);

but in pngutil.c we see this:

png_chunk_error(png_ptr, "CRC error");

The upshot is that it will copy 54 bytes past the end of the
error string. This could cause a core dump.

Version-Release number of selected component (if applicable):
libpng-1.2.2-19.1

How reproducible:
Always

Steps to Reproduce:
Found during code review
    

Additional info:

I will attach a patch that measures the message's length and adjusts
the memcpy accordingly.
Comment 1 Steve Grubb 2004-04-09 17:06:38 UTC 
Created attachment 99278 [details]
Patch that fixes the problem

Please apply before Fedora Core 2 final.
Comment 2 Matthias Clasen 2004-04-23 14:14:04 UTC 

*** This bug has been marked as a duplicate of 121229 ***
Comment 3 Red Hat Bugzilla 2006-02-21 19:02:30 UTC 
Changed to 'CLOSED' state since 'RESOLVED' has been deprecated.