Bug 1205661

Summary:	Sharding translator - bug fixes
Product:	[Community] GlusterFS	Reporter:	Krutika Dhananjay <kdhananj>
Component:	sharding	Assignee:	Krutika Dhananjay <kdhananj>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7dev-0.869.gitf5e4c94.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-05-14 17:27:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1199352

Description Krutika Dhananjay 2015-03-25 12:36:22 UTC

Description of problem:

This bug has been created for tracking all bugs that need to go in to 3.7 that are related to sharding.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2015-03-26 06:47:14 UTC

REVIEW: http://review.gluster.org/10003 (features/shard: Bug fixes) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 2 Anand Avati 2015-03-27 18:27:29 UTC

COMMIT: http://review.gluster.org/10003 committed in master by Vijay Bellur (vbellur) 
------
commit 651514dd66019a9f37dfa96374e31dd497a18a59
Author: Krutika Dhananjay <kdhananj>
Date:   Tue Mar 24 11:36:59 2015 +0530

    features/shard: Bug fixes
    
    * Return number of bytes written in writev cbk on success
    * Eliminate separate inode table for sharding xlator.
    * Fix appearance of "shard" as an option within the
      volfile for subvolume of type features/shard.
    * Fix values of min and max allowed shard block size
    * Return @new as opposed to NULL in shard_create_gfid_dict() on success
    
    Change-Id: I6319d377a196d1c5ceed1f65d337ff8eabcb21f8
    BUG: 1205661
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/10003
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 3 Anand Avati 2015-04-01 11:50:29 UTC

REVIEW: http://review.gluster.org/10094 (features/shard: Fail writes if /.shard already exists as a file) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 4 Anand Avati 2015-04-01 11:50:32 UTC

REVIEW: http://review.gluster.org/10095 (features/shard: Create and use xattr_req dict as and when needed) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 5 Anand Avati 2015-04-01 11:50:35 UTC

REVIEW: http://review.gluster.org/10096 (features/shard: Refactor code) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 6 Anand Avati 2015-04-03 13:34:04 UTC

COMMIT: http://review.gluster.org/10094 committed in master by Vijay Bellur (vbellur) 
------
commit 5599165e09e5c5e2862996b5f92cf1a1227b9039
Author: Krutika Dhananjay <kdhananj>
Date:   Wed Apr 1 14:04:36 2015 +0530

    features/shard: Fail writes if /.shard already exists as a file
    
    Change-Id: Id7250ca4637c37a005cf2def43d5b843c1ea6562
    BUG: 1205661
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/10094
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 7 Anand Avati 2015-04-04 17:46:12 UTC

COMMIT: http://review.gluster.org/10095 committed in master by Vijay Bellur (vbellur) 
------
commit 0aebfaa349c7c68c2d59531eabae5a03a748e16a
Author: Krutika Dhananjay <kdhananj>
Date:   Wed Apr 1 14:39:01 2015 +0530

    features/shard: Create and use xattr_req dict as and when needed
    
    Reusing local->xattr_req for the several calls and callbacks per xlator fop
    would cause keys set from previous call/cbk (sometimes even by the xlators
    below) to remain which in some cases can lead to errors.  For instance, the
    presence of "trusted.glusterfs.dht.*" keys (which are remnants of the previous
    call/cbk), can cause the GF_IF_INTERNAL_XATTR_GOTO() check in DHT to fail when
    the same dict is used to wind [f]setxattr.
    
    Change-Id: I8612d020f83f3dc55e4a34d10ccbdaf11d7b4fdd
    BUG: 1205661
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/10095
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 8 Anand Avati 2015-04-06 04:44:03 UTC

REVIEW: http://review.gluster.org/10096 (features/shard: Refactor code) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

Comment 9 Anand Avati 2015-04-07 06:09:34 UTC

COMMIT: http://review.gluster.org/10096 committed in master by Vijay Bellur (vbellur) 
------
commit d1a5c805610115122b8ef61367b61425d7e39db5
Author: Krutika Dhananjay <kdhananj>
Date:   Wed Apr 1 15:13:11 2015 +0530

    features/shard: Refactor code
    
    * Renamed shard_writev_create_write_shards() to shard_common_resolve_shards()
      to appropriately reflect its functionality and for reuse in other fops too.
    
    * Move code common to MKNOD and CREATE into a macro.
    
    * Cut down on if nesting in shard_lookup_cbk()
    
    Change-Id: I488255499673accd426390c6d42f2b39bab3d637
    BUG: 1205661
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/10096
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 10 Niels de Vos 2015-05-14 17:27:01 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 11 Niels de Vos 2015-05-14 17:28:33 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 12 Niels de Vos 2015-05-14 17:35:17 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user