Bug 1205779

Summary: Class cannot update values in a class schema when Instances of that class exist.
Product: Red Hat CloudForms Management Engine Reporter: ldomb
Component: UI - OPSAssignee: Harpreet Kataria <hkataria>
Status: CLOSED ERRATA QA Contact: Dave Johnson <dajohnso>
Severity: high Docs Contact:
Priority: high    
Version: 5.3.0CC: dclarizi, hkataria, jhardy, kmorey, mberube, mkanoor, mpovolny, obarenbo, sshveta, tfitzger
Target Milestone: GA   
Target Release: 5.4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1209186 (view as bug list) Environment:
Last Closed: 2015-06-16 12:55:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1209186    

Description ldomb 2015-03-25 15:25:19 UTC
Description of problem:
Cannot update password in class schema after creating other instances of that class

Version-Release number of selected component (if applicable):
5.3.3.2.20150217120931_a465215 

How reproducible:


Steps to Reproduce:
1. Create a new Class in the automate model
2. Add a password field and add a password to the schema
3. Create create an instance and override the password. 
4. Change the password in the Class schema. 

Actual results:
Cannot update password in Class schema

Expected results:
Can update password in Class schema

Additional info:

Comment 2 Greg McCullough 2015-03-25 15:57:07 UTC
Madhu - We first need to determine if this is a UI or model issue.

Comment 3 mkanoor 2015-03-25 19:16:05 UTC
Dan - This looks like a UI issue I tested this on non-password fields and we can change  the schema. The Class schema editor doesn't light up the save button if the password field is updated.

Comment 5 CFME Bot 2015-03-31 23:10:51 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/ffddb118ffd8d8730d86b925c3e479bf4cd584ba

commit ffddb118ffd8d8730d86b925c3e479bf4cd584ba
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon Mar 30 18:54:29 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Mon Mar 30 19:04:21 2015 -0400

    Use params fields_password_value_x to set field value for password field
    
    If data type is changed to password when adding new schema field, don't show value entered in plain text, switch to password field.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1205779

 vmdb/app/controllers/miq_ae_class_controller.rb | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

Comment 6 CFME Bot 2015-04-06 17:05:48 UTC
New commit detected on cfme/5.3.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=16806d3e5701c50cd6abddb05328454905bc2e40

commit 16806d3e5701c50cd6abddb05328454905bc2e40
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon Mar 30 19:04:21 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Mon Apr 6 12:54:07 2015 -0400

    Use params fields_password_value_x to set field value for password field
    
    If data type is changed to password when adding new schema field, don't show value entered in plain text, switch to password field.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1205779
    (cherry picked from commit ffddb11)
    https://bugzilla.redhat.com/show_bug.cgi?id=1209186

 vmdb/app/controllers/miq_ae_class_controller.rb | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

Comment 7 CFME Bot 2015-04-06 17:05:56 UTC
New commit detected on cfme/5.3.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=e7d3e2cb1672d41c9696e21c193e2c8684dd54f7

commit e7d3e2cb1672d41c9696e21c193e2c8684dd54f7
Merge: 73da371 16806d3
Author:     Dan Clarizio <dclarizi>
AuthorDate: Mon Apr 6 13:02:19 2015 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Mon Apr 6 13:02:19 2015 -0400

    Merge branch 'bz_1209186' into '5.3.z'
    
    Use params fields_password_value_x to set field value for password field
    
    16806d3e5701c50cd6abddb05328454905bc2e40
    Harpreet Kataria at 3/30/15 7:04 PM (committed at 4/6/15 12:54 PM)
    
    Use params fields_password_value_x to set field value for password field
    
    If data type is changed to password when adding new schema field, don't show value entered in plain text, switch to password field.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1205779
    (cherry picked from commit ffddb11)
    https://bugzilla.redhat.com/show_bug.cgi?id=1209186
    
    @dclarizio please review, had to make JS changes by hand in controller as we have JS helper methods on master now. Recreated/Tested on 5.3.z
    
    See merge request !23

 vmdb/app/controllers/miq_ae_class_controller.rb | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

Comment 9 Shveta 2015-04-21 22:02:51 UTC
Fixed in 5.4.0.0.22.20150420163946_26004d1

Comment 11 errata-xmlrpc 2015-06-16 12:55:13 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html