Bug 1206029

Summary: User role selection is not honored if I uncheck "Everything" in WebUI.
Product: Red Hat CloudForms Management Engine Reporter: Chen <cchen>
Component: UI - OPSAssignee: Harpreet Kataria <hkataria>
Status: CLOSED ERRATA QA Contact: Aziza Karol <akarol>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.3.0CC: cpelland, hkataria, jhardy, mfeifer, mpovolny, obarenbo
Target Milestone: GAKeywords: ZStream
Target Release: 5.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.5.0.1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1230334 (view as bug list) Environment:
Last Closed: 2015-12-08 13:04:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1230334    

Description Chen 2015-03-26 07:27:18 UTC
Description of problem:

User role selection is not honored if I uncheck "Everything" in WebUI.

Version-Release number of selected component (if applicable):

CFME 5.3.2

How reproducible:

100%

Steps to Reproduce:
1.Create a Role called testrole. When setting "Product Features", check out "Everything" and select "Infrastructure" and Add.

2. And then we have a look at testrole, Infrastructure became grey, which indicates some check boxes are not checked. The result is [Infrastructure]->[Virtual Machines]->[Template Access Rules] and [VM Access Rules] are unexpectedly checked out.

3. Create a corresponding Group and User (testuser1) based on testrole. ( testrole has full access to Infrastructure ).

4. Login as testuser1 and see the drift history of a certain VM.

Actual results:

testuser1 can not drift the Smart Analysis History.

Expected results:

testuser1 should have the ability to drift the Smart Analysis History.

Additional info:

Let's change the method we created the role in step 3. We don't first check out "Everything", but we check out all the settings one by one except "Infrastructure". And after that, create Group and User (testuser2) based on the role we just created. This time, testuser2 can see the result of the drift history.

Comment 2 CFME Bot 2015-06-05 22:01:04 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/765d34a695418cca3292a1832dc89c38fa0d02fd

commit 765d34a695418cca3292a1832dc89c38fa0d02fd
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu Jun 4 12:32:53 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Thu Jun 4 18:18:50 2015 -0400

    Fixed RBAC feature id.
    
    Fixed RBAC feature id that was causing certain features to not be selected when selecting top level Infrastructure/Cloud tab in order to give user access to all features under Infrastructure/Cloud tab. Fixed feature id in EXPLORER_FEATURE_LINKS constant and fixed broken spec test.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1206029

 vmdb/app/controllers/dashboard_controller.rb       | 14 +++++++-------
 vmdb/app/presenters/menu/default_menu.rb           |  4 ++--
 vmdb/spec/controllers/dashboard_controller_spec.rb |  6 +++---
 3 files changed, 12 insertions(+), 12 deletions(-)

Comment 3 CFME Bot 2015-06-05 22:01:07 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/5717826088ddd9d2dcdf170845781d50a47d5690

commit 5717826088ddd9d2dcdf170845781d50a47d5690
Author:     Harpreet Kataria <hkataria>
AuthorDate: Fri Jun 5 09:45:08 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Fri Jun 5 09:45:08 2015 -0400

    Addressed rubocop comments
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1206029

 vmdb/app/controllers/dashboard_controller.rb       | 14 +++++++-------
 vmdb/spec/controllers/dashboard_controller_spec.rb |  8 ++++----
 2 files changed, 11 insertions(+), 11 deletions(-)

Comment 4 CFME Bot 2015-07-14 21:59:43 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=ddb3d392e6837429810db37777f8ae2d9e58051f

commit ddb3d392e6837429810db37777f8ae2d9e58051f
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu Jun 4 12:32:53 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Wed Jun 10 12:53:33 2015 -0400

    Fixed RBAC feature id.
    
    Fixed RBAC feature id that was causing certain features to not be selected when selecting top level Infrastructure/Cloud tab in order to give user access to all features under Infrastructure/Cloud tab. Fixed feature id in EXPLORER_FEATURE_LINKS constant and fixed broken spec test.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1206029
    (cherry picked from commit 765d34a)
    https://bugzilla.redhat.com/show_bug.cgi?id=1230334

 vmdb/app/controllers/dashboard_controller.rb       | 14 +++++++-------
 vmdb/app/presenters/menu/default_menu.rb           |  4 ++--
 vmdb/spec/controllers/dashboard_controller_spec.rb |  6 +++---
 3 files changed, 12 insertions(+), 12 deletions(-)

Comment 5 CFME Bot 2015-07-14 21:59:47 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=a696d78466698b78a99555b69df2fd0f5f94ffdc

commit a696d78466698b78a99555b69df2fd0f5f94ffdc
Author:     Harpreet Kataria <hkataria>
AuthorDate: Fri Jun 5 09:45:08 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Wed Jun 10 12:53:59 2015 -0400

    Addressed rubocop comments
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1206029
    (cherry picked from commit 5717826)
    https://bugzilla.redhat.com/show_bug.cgi?id=1230334

 vmdb/app/controllers/dashboard_controller.rb       | 14 +++++++-------
 vmdb/spec/controllers/dashboard_controller_spec.rb |  8 ++++----
 2 files changed, 11 insertions(+), 11 deletions(-)

Comment 6 bmorriso 2015-09-15 18:52:24 UTC
verified in upstream master.20150915143408_88f28a0

[Template Access Rules] and [VM Access Rules] are checked properly when following the steps in the description, and the testuser1 that was created can access drift history.

Comment 7 Aziza Karol 2015-11-27 09:25:10 UTC
user created can access drift history.

verified and working fine in 5.5.0.12-rc2.20151124135609_653c0d4

Comment 9 errata-xmlrpc 2015-12-08 13:04:25 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:2551