Bug 1206370

Summary: Format the puppet error state email
Product: Red Hat Satellite Reporter: sthirugn <sthirugn>
Component: Content ManagementAssignee: Shlomi Zadok <szadok>
Status: CLOSED CURRENTRELEASE QA Contact: Tazim Kolhar <tkolhar>
Severity: high Docs Contact:
Priority: unspecified    
Version: 6.1.0CC: bkearney, cwelton, omaciel, sthirugn, tkolhar
Target Milestone: Unspecified   
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
URL: http://projects.theforeman.org/issues/9998
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-08-12 13:55:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description sthirugn@redhat.com 2015-03-26 21:59:16 UTC
Description of problem:
Format the puppet error state email

Version-Release number of selected component (if applicable):
Satellite-6.1.0-RHEL-7-20150324.0

How reproducible:
Always

Steps to Reproduce:
1. Trigger a puppet error in a provisioned host
2. Review the puppet error state email

Actual results:
Right now, the email is not formatted.

Expected results:
The email should be formatted like the other notification emails (Publish, promotion, Host advisory, etc)

Additional info:

Comment 1 RHEL Program Management 2015-03-26 22:03:11 UTC
Since this issue was entered in Red Hat Bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.

Comment 4 Shlomi Zadok 2015-04-02 07:34:07 UTC
Created redmine issue http://projects.theforeman.org/issues/9998 from this bug

Comment 5 Shlomi Zadok 2015-04-14 14:53:41 UTC
Created https://github.com/theforeman/foreman/pull/2284 to fix this issue

Comment 6 Bryan Kearney 2015-04-21 10:06:02 UTC
Moving to POST since upstream bug http://projects.theforeman.org/issues/9998 has been closed
-------------
Shlomi Zadok
Applied in changeset commit:63287a97004fd37c40682fde964d03421ab849c8.

Comment 8 Tazim Kolhar 2015-04-29 07:12:38 UTC
hi

please provide verification steps

thanks

Comment 10 Shlomi Zadok 2015-05-05 11:36:19 UTC
verification steps:
1. Trigger a puppet error in a provisioned host
2. Review the puppet error state email

expected result:
email should be formatted like other emails coming from Foreman

Comment 13 Tazim Kolhar 2015-05-07 12:49:40 UTC
The identations in the file were important 
it worked know
moving it to ON_QA
thanks

Comment 14 Tazim Kolhar 2015-05-26 10:37:25 UTC
VERIFIED:
# rpm -qa  |grep foreman
foreman-1.7.2.24-1.el7sat.noarch
ruby193-rubygem-foreman-tasks-0.6.12.5-1.el7sat.noarch
foreman-libvirt-1.7.2.24-1.el7sat.noarch
ruby193-rubygem-foreman_gutterball-0.0.1.9-1.el7sat.noarch
hp-sl2x170zg6-02.rhts.eng.bos.redhat.com-foreman-client-1.0-1.noarch
hp-sl2x170zg6-02.rhts.eng.bos.redhat.com-foreman-proxy-client-1.0-1.noarch
foreman-gce-1.7.2.24-1.el7sat.noarch
rubygem-hammer_cli_foreman-0.1.4.11-1.el7sat.noarch
foreman-selinux-1.7.2.13-1.el7sat.noarch
foreman-ovirt-1.7.2.24-1.el7sat.noarch
ruby193-rubygem-foreman-redhat_access-0.1.0-1.el7sat.noarch
rubygem-hammer_cli_foreman_tasks-0.0.3.4-1.el7sat.noarch
foreman-postgresql-1.7.2.24-1.el7sat.noarch
foreman-debug-1.7.2.24-1.el7sat.noarch
foreman-vmware-1.7.2.24-1.el7sat.noarch
ruby193-rubygem-foreman_hooks-0.3.7-2.el7sat.noarch
rubygem-hammer_cli_foreman_bootdisk-0.1.2.7-1.el7sat.noarch
rubygem-hammer_cli_foreman_docker-0.0.3.6-1.el7sat.noarch
foreman-proxy-1.7.2.4-1.el7sat.noarch
ruby193-rubygem-foreman_bootdisk-4.0.2.13-1.el7sat.noarch
hp-sl2x170zg6-02.rhts.eng.bos.redhat.com-foreman-proxy-1.0-2.noarch
ruby193-rubygem-foreman_docker-1.2.0.14-1.el7sat.noarch
rubygem-hammer_cli_foreman_discovery-0.0.1.10-1.el7sat.noarch
foreman-compute-1.7.2.24-1.el7sat.noarch
ruby193-rubygem-foreman_discovery-2.0.0.14-1.el7sat.noarch

steps:
To trigger Puppet error state email:
1. Add a puppet module (eg: apache) to the content view, publish, promote
2. Edit the provisioned host - add 1 or more puppet class (which requires input parameter) from the puppet module and do not supply the input parameter
3. Run puppet agent: /usr/bin/puppet agent --no_daemonize
4. Make sure to review the notification email
for emails notification settings:
 vi /etc/foreman/email.yaml
# Outgoing email settings

production:
  delivery_method: :smtp
  smtp_settings:
    address: smtp.corp.redhat.com
    port: 25
    domain: example.com
    authentication: :none
    enable_starttls_auto: false

Comment 15 Bryan Kearney 2015-08-11 13:19:16 UTC
This bug is slated to be released with Satellite 6.1.

Comment 16 Bryan Kearney 2015-08-12 13:55:48 UTC
This bug was fixed in version 6.1.1 of Satellite which was released on 12 August, 2015.