Bug 1206406
Summary: | blockcopy to a gluster volume calls drive-mirror with wrong parameters | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 7 | Reporter: | Luyao Huang <lhuang> |
Component: | libvirt | Assignee: | Ján Tomko <jtomko> |
Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 7.2 | CC: | dyuan, jtomko, mzhan, rbalakri, shyu, yanyang |
Target Milestone: | rc | ||
Target Release: | --- | ||
Hardware: | x86_64 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | libvirt-1.2.14-1.el7 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-11-19 06:25:41 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Luyao Huang
2015-03-27 02:56:53 UTC
Fixed upstream by: commit c5fbad66234b1b1a9afc36ef2fe3a3d903886386 Author: Shanzhi Yu <shyu> CommitDate: 2015-03-27 10:30:50 +0100 qemu: end the job when try to blockcopy to non-file destination Blockcopy to non-file destination is not supported according the code, but a 'goto endjob' is missed after checking the destination. This leads to calling drive-mirror with wrong parameters. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1206406 Signed-off-by: Shanzhi Yu <shyu> Signed-off-by: Ján Tomko <jtomko> git describe: v1.2.14-rc1-2-gc5fbad6 Verify this bug with libvirt-1.2.16-1.el7.x86_64 libvirt-1.2.16-1.el7.x86_64 1. Prepare transient guest # virsh list --transient Id Name State ---------------------------------------------------- 4 vol-d running 2. Prepare destination file # cat gluster.xml <disk type='network' device='disk'> <driver name='qemu' type='raw' cache='none'/> <source protocol='gluster' name='gluster-vol1/rh6.img.s2'> <host name='10.66.x.xxx'/> </source> <target dev='vdb' bus='virtio'/> <shareable/> <address type='pci' domain='0x0000' bus='0x00' slot='0x0a' function='0x0'/> </disk> # cat rbd.xml <disk type='network' device='disk'> <driver name='qemu' type='raw' cache='none'/> <source protocol='rbd' name='libvirt-pool/test.img'> <host name='10.66.x.xxx'/> <host name='10.66.x.xxx'/> <host name='10.66.x.xxx'/> </source> <target dev='vdb' bus='virtio'/> <shareable/> <address type='pci' domain='0x0000' bus='0x00' slot='0x0a' function='0x0'/> </disk> # virsh blockcopy vol-d vdb --xml rbd.xml error: argument unsupported: non-file destination not supported yet # virsh blockcopy vol-d vdb --xml gluster.xml error: argument unsupported: non-file destination not supported yet I have a problem. when do block copy to a local file with absolute/relative path we don't need option "--dest", while if do block copy with "dest.xml", --xml is needed. otherwise it will treat dest.xml file as the real destination file. # virsh blockcopy r7 vdb error: need either --dest or --xml # virsh blockcopy r7 vdb rbd.xml Block Copy started Should libvirt can recognise it is a config file but not a destination file path when pass a xml file to it ? Without this problem, this bug can be verified. virsh should not guess whether it's a config file based on the extension or its contents. The third parameter is assumed to be the destination, I have sent a patch against the virsh manual to clarify that: https://www.redhat.com/archives/libvir-list/2015-June/msg00629.html Thanks, verify this bug. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-2202.html |