Bug 1206732

Summary:	Review Request: python-gccjit - Python bindings for libgccjit
Product:	[Fedora] Fedora	Reporter:	Dave Malcolm <dmalcolm>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED INSUFFICIENT_DATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, ppisar, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review?
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-02-11 13:58:20 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449

Description Dave Malcolm 2015-03-27 21:57:45 UTC

Spec URL:
https://dmalcolm.fedorapeople.org/python-packaging/python-gccjit.spec

SRPM URL:
https://dmalcolm.fedorapeople.org/python-packaging/python-gccjit-0.4-1.fc23.src.rpm

Description:
Python bindings for libgccjit

Fedora Account System Username: dmalcolm

Builds cleanly in mock for rawhide x86_64.
The rpmlint output of said build is as follows:
$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm
python3-gccjit.x86_64: W: spelling-error Summary(en_US) libgccjit 
python3-gccjit.x86_64: W: spelling-error %description -l en_US libgccjit 
python3-gccjit.x86_64: E: non-standard-executable-perm /usr/lib64/python3.4/site-packages/gccjit/_gccjit.cpython-34m.so 0775L
python3-gccjit.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/gccjit/__pycache__/__init__.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python3-gccjit.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/gccjit/__pycache__/__init__.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python-gccjit.src: W: spelling-error Summary(en_US) libgccjit 
python-gccjit.src: W: spelling-error %description -l en_US libgccjit 
python-gccjit.x86_64: W: spelling-error Summary(en_US) libgccjit 
python-gccjit.x86_64: W: spelling-error %description -l en_US libgccjit 
python-gccjit.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gccjit/_gccjit.so 0775L
4 packages and 0 specfiles checked; 4 errors, 6 warnings.

(this rpmlint is on a Fedora 20 box)

The "spelling-error" errors appear to be false positives.
The "non-standard-executable-perm" is a Cython-built .so coming out as 0775 rather than 0755.  This may be a Cython bug.
The "python-bytecode-wrong-magic-value" is presumably due to running Fedora 20's rpmlint.

Comment 1 Dave Malcolm 2015-03-27 21:59:32 UTC

Specfile can also be seen at https://github.com/davidmalcolm/python-gccjit-srpm

Comment 2 Zbigniew Jędrzejewski-Szmek 2015-07-30 15:33:44 UTC

> %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from 
> distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}

> %if 0%{?fedora} > 12

You can drop that, unless you want to package for old EPELs too.

Must Provide: python2-gccjit = %{version}-%{release}

Do you need the whole dance with %{py3dir}? Unless you use 2to3 or modify the sources during build in another way, it should be fine to build both versions from the same source directory.

> rm -rf $RPM_BUILD_ROOT
Allowed, but also obsolete.

Also consider adding %global _docdir_fmt %{name}. No need for duplicate dirs with the same contents.

Comment 3 Zbigniew Jędrzejewski-Szmek 2015-07-30 15:35:01 UTC

- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file COPYING is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text