Bug 1206877
| Summary: | Review Request: golang-github-dchest-cssmin - Go port of Ryan Grove's cssmin. | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Alessandro Locati <fale> |
| Component: | Package Review | Assignee: | Jan Chaloupka <jchaloup> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | athoscribeiro, fale, jchaloup, package-review |
| Target Milestone: | --- | Flags: | jchaloup:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-04-04 16:01:59 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1426972 | ||
|
Description
Fabio Alessandro Locati
2015-03-29 09:19:15 UTC
Summary: - license is OK - list of provides OK - list of dependencies (none) OK $ rpmlint /home/jchaloup/rpmbuild/SRPMS/golang-github-dchest-cssmin-0-0.1.gita22e1d8.fc20.src.rpm /home/jchaloup/rpmbuild/RPMS/noarch/golang-github-dchest-cssmin-devel-0-0.1.gita22e1d8.fc20.noarch.rpm golang-github-dchest-cssmin.src: W: summary-ended-with-dot C Go port of Ryan Grove's cssmin. golang-github-dchest-cssmin-devel.noarch: W: summary-ended-with-dot C Go port of Ryan Grove's cssmin. 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Summary should not end with dot. Can you, please, remove it? There is no LICENSE file although README.md mentions it is BSD. Can you copy license text from cssmin.go to LICENSE file? Thanks jchaloup's scratch build of go-memdb-9ea975b.tar.gz for cli-build/1454938967.533693.wYGVMBzT/go-memdb-9ea975b.tar.gz and f22-candidate failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12902531 There's a new commit with a LICENSE file [1] https://github.com/dchest/cssmin/commit/fb8d9b44afdc258bfff6052d3667521babcb2239 Hello Fabio, Are you still interested in going on with this? If not, I will take over, since I got a package depending on this one Hi Athos, I packaged this because my goal was to package Hugo, but I never had enough time to package all dependencies etc. I've noticed that you are packaging Hugo, so I think it would make sense if you also pick up this one. Thanks a lot for your effort packaging Hugo :). Fale New sources Spec URL: https://athoscr.fedorapeople.org/packaging/golang-github-dchest-cssmin.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/golang-github-dchest-cssmin-0-0.3.gitfb8d9b4.fc25.src.rpm Thank you for the package and the review!!! Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-dchest-cssmin golang-github-dchest-cssmin-0-0.3.gitfb8d9b4.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6411360055 golang-github-dchest-cssmin-0-0.3.gitfb8d9b4.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6411360055 golang-github-dchest-cssmin-0-0.3.gitfb8d9b4.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |