Bug 1206883

Summary: Review Request: golang-github-PuerkitoBio-urlesc - Package urlesc implements query escaping as per RFC 3986.
Product: [Fedora] Fedora Reporter: Fabio Alessandro Locati <fale>
Component: Package ReviewAssignee: Jan Chaloupka <jchaloup>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: athoscribeiro, fale, jchaloup, package-review
Target Milestone: ---Flags: jchaloup: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-04-04 16:02:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1394576    

Comment 1 Fabio Alessandro Locati 2015-03-29 10:00:37 UTC
*** Bug 1206882 has been marked as a duplicate of this bug. ***

Comment 2 Jan Chaloupka 2015-04-02 14:05:05 UTC
$ rpmlint /home/jchaloup/rpmbuild/SRPMS/golang-github-opennota-urlesc-0-0.1.git5fa9ff0.fc20.src.rpm /home/jchaloup/rpmbuild/RPMS/noarch/golang-github-opennota-urlesc-devel-0-0.1.git5fa9ff0.fc20.noarch.rpm
golang-github-opennota-urlesc.src: W: summary-ended-with-dot C Package urlesc implements query escaping as per RFC 3986.
golang-github-opennota-urlesc-devel.noarch: W: summary-ended-with-dot C Package urlesc implements query escaping as per RFC 3986.
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Summary should not end with dot. Please remove it.

- licence BSD - OK
- all provides OK
- no dependencies - OK

Comment 3 Upstream Release Monitoring 2015-12-10 16:23:44 UTC
fale's scratch build of golang-github-opennota-urlesc-0-0.2.git5fa9ff0.fc23.src.rpm for f23 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12139324

Comment 4 Athos Ribeiro 2016-11-13 16:49:59 UTC
I Believe upstream changed the namespace [1]. Should the package name change before a repo is created here?

[1] See https://github.com/PuerkitoBio/urlesc (opennota redirects here)

Comment 5 Athos Ribeiro 2016-11-13 18:09:09 UTC
Maybe it should Provide both golang-github-opennota-urlesc and golang-github-PuerkitoBio-urlesc

Comment 6 Athos Ribeiro 2017-03-04 17:32:24 UTC
Hello Fabio,

Are you still interested in this package? If not, and if you do not oppose, I will take over. If I do, I will change the package namespace as upstream did, as reported in comment #4.

Comment 7 Fabio Alessandro Locati 2017-03-05 17:04:53 UTC
Hi Athos,
I packaged this because my goal was to package Hugo, but I never had enough time to package all dependencies etc.
I've noticed that you are packaging Hugo, so I think it would make sense if you also pick up this one.

Thanks a lot for your effort packaging Hugo :).
Fale

Comment 8 Athos Ribeiro 2017-03-06 20:58:54 UTC
Hello,

I renamed the package namespace, since upstream did so a while ago (opennota/urlesc redirects to PuerkitoBio/urlesc on github).

Spec URL: https://athoscr.fedorapeople.org/packaging/golang-github-PuerkitoBio-urlesc.spec
SRPM URL: https://athoscr.fedorapeople.org/packaging/golang-github-PuerkitoBio-urlesc-0-0.3.git5bd2802.fc25.src.rpm

Comment 9 Athos Ribeiro 2017-03-06 21:16:32 UTC
Thanks for your review, Jan! And thanks for the package, Fabio!

Comment 10 Gwyn Ciesla 2017-03-07 13:33:31 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-PuerkitoBio-urlesc

Comment 11 Fedora Update System 2017-03-07 15:31:37 UTC
golang-github-PuerkitoBio-urlesc-0-0.3.git5bd2802.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-410c063af1

Comment 12 Fedora Update System 2017-03-10 23:19:48 UTC
golang-github-PuerkitoBio-urlesc-0-0.3.git5bd2802.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-410c063af1

Comment 13 Fedora Update System 2017-04-04 16:02:06 UTC
golang-github-PuerkitoBio-urlesc-0-0.3.git5bd2802.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.