Bug 1207095
| Summary: | host-passthrough model cpu with feature policy will be covered by host cpu after migrate/restore | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Luyao Huang <lhuang> |
| Component: | libvirt | Assignee: | Jiri Denemark <jdenemar> |
| Status: | CLOSED ERRATA | QA Contact: | Jingjing Shao <jishao> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 7.2 | CC: | dyuan, knoel, mzhan, rbalakri, xuzhang |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | libvirt-2.5.0-1.el7 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-08-01 17:06:41 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1199452, 1288337 | ||
Just send a patch to upstream: http://www.redhat.com/archives/libvir-list/2015-March/msg01520.html Resend a new one: https://www.redhat.com/archives/libvir-list/2015-June/msg00871.html This should be fixed upstream as of
commit 7ce711a30eaf882ccd0217b2528362b563b6d670
Refs: v2.2.0-199-g7ce711a
Author: Jiri Denemark <jdenemar>
AuthorDate: Wed Jun 22 15:53:48 2016 +0200
Commit: Jiri Denemark <jdenemar>
CommitDate: Thu Sep 22 15:40:09 2016 +0200
qemu: Update guest CPU def in live XML
Storing the updated CPU definition in the live domain definition saves
us from having to update it over and over when we need it. Not to
mention that we will soon further update the CPU definition according to
QEMU once it's started.
A highly wanted side effect of this patch, libvirt will pass all CPU
features explicitly specified in domain XML to QEMU, even those that are
already included in the host model.
This patch should fix the following bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1207095
https://bugzilla.redhat.com/show_bug.cgi?id=1339680
https://bugzilla.redhat.com/show_bug.cgi?id=1371039
https://bugzilla.redhat.com/show_bug.cgi?id=1373849
https://bugzilla.redhat.com/show_bug.cgi?id=1375524
https://bugzilla.redhat.com/show_bug.cgi?id=1377913
Signed-off-by: Jiri Denemark <jdenemar>
Verified this bug as below
# rpm -q libvirt
libvirt-2.5.0-1.el7.x86_64
# virsh start rhel7.3
Domain rhel7.3 started
# virsh dumpxml rhel7.3 | grep cpu -A3
...
<cpu mode='host-passthrough'>
<feature policy='disable' name='bmi1'/>
</cpu>
...
# virsh managedsave rhel7.3
Domain rhel7.3 state saved by libvirt
# virsh restore /var/lib/libvirt/qemu/save/rhel7.3.save
Domain restored from /var/lib/libvirt/qemu/save/rhel7.3.save
# virsh dumpxml rhel7.3 | grep cpu -A3
...
<cpu mode='host-passthrough'>
<feature policy='disable' name='bmi1'/>
</cpu>
...
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2017:1846 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2017:1846 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2017:1846 |
description of problem: host-passthrough model cpu with feature policy will disappear after migrate/save and restore Version-Release number of selected component (if applicable): libvirt-1.2.13-1.el7.x86_64 How reproducible: 100% Steps to Reproduce: 1.edit a vm like this: # virsh edit test3 <cpu mode='host-passthrough'> <feature policy='disable' name='bmi1'/> </cpu> 2.start it and check running vm xml: # virsh start test3 # virsh dumpxml test3 <cpu mode='host-passthrough'> <feature policy='disable' name='bmi1'/> </cpu> 3. managedsave and restore # virsh managedsave test3 Domain test3 state saved by libvirt # virsh start test3 Domain test3 started # virsh dumpxml ... <cpu mode='host-passthrough'> <feature policy='require' name='bmi1'/> <feature policy='require' name='perfctr_nb'/> <feature policy='require' name='perfctr_core'/> <feature policy='require' name='topoext'/> <feature policy='require' name='nodeid_msr'/> <feature policy='require' name='tce'/> <feature policy='require' name='lwp'/> <feature policy='require' name='wdt'/> <feature policy='require' name='skinit'/> <feature policy='require' name='ibs'/> <feature policy='require' name='osvw'/> <feature policy='require' name='cr8legacy'/> <feature policy='require' name='extapic'/> <feature policy='require' name='cmp_legacy'/> <feature policy='require' name='fxsr_opt'/> <feature policy='require' name='mmxext'/> <feature policy='require' name='osxsave'/> <feature policy='require' name='monitor'/> <feature policy='require' name='ht'/> <feature policy='require' name='vme'/> </cpu> ... Actual results: host-passthrough model cpu with feature policy will disappear after migrate/save and restore Expected results: still can find them after restore/migrate Additional info: Also we should check if user will try to set invtsc flags then migrate