Bug 1207238

Summary:	data tiering:force Remove brick is detaching-tier
Product:	[Community] GlusterFS	Reporter:	Nag Pavan Chilakam <nchilaka>
Component:	tiering	Assignee:	Mohammed Rafi KC <rkavunga>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	mainline	CC:	bugs, hchiramm, rkavunga, sankarshan
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-4.1.4	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1229242 (view as bug list)		Environment:
Last Closed:	2018-10-08 09:53:22 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1229242, 1260923

Description Nag Pavan Chilakam 2015-03-30 13:36:29 UTC

Description of problem:
=======================
In a tiered volume,removing a brick fails.
So if we try force remove-brick , either on cold or hot, it just goes and detaches tier. This is a serious bug


Version-Release number of selected component (if applicable):
============================================================
3.7 upstream nightlies build http://download.gluster.org/pub/gluster/glusterfs/nightly/glusterfs/epel-6-x86_64/glusterfs-3.7dev-0.821.git0934432.autobuild//

root@interstellar glusterfs]# gluster --version
glusterfs 3.7dev built on Mar 28 2015 01:05:28
Repository revision: git://git.gluster.com/glusterfs.git
Copyright (c) 2006-2011 Gluster Inc. <http://www.gluster.com>
GlusterFS comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of GlusterFS under the terms of the GNU General Public License.


How reproducible:
=================
Easy to reproduce


Steps to Reproduce:
==================
1.create a gluster volume(i created a distribute type) and start the volume and attach a tier to the volume using attach-tier


2.Now do  a remove-brick and use force option as below
gluster v remove-brick voly transformers:/pavanbrick2/voly/hb1 force
Removing brick(s) can result in data loss. Do you want to Continue? (y/n) y
volume remove-brick commit force: success

3. This forcefully just detaches tier instead of the brick

Expected results:
================
remove a  brick should not remove the tier

Additional info(CLI logs):
=========================
[root@interstellar glusterfs]# gluster v create voly interstellar:/pavanbrick1/voly/b1 transformers:/pavanbrick1/voly/b1
volume create: voly: success: please start the volume to access data
[root@interstellar glusterfs]# gluster v start voly
volume start: voly: success
[root@interstellar glusterfs]# gluster v info voly
 
Volume Name: voly
Type: Distribute
Volume ID: 22412494-df85-4458-a80f-0e4c0cc76572
Status: Started
Number of Bricks: 2
Transport-type: tcp
Bricks:
Brick1: interstellar:/pavanbrick1/voly/b1
Brick2: transformers:/pavanbrick1/voly/b1
[root@interstellar glusterfs]# gluster v status voly
Status of volume: voly
Gluster process                             TCP Port  RDMA Port  Online  Pid
------------------------------------------------------------------------------
Brick interstellar:/pavanbrick1/voly/b1     49158     0          Y       27482
Brick transformers:/pavanbrick1/voly/b1     49158     0          Y       31954
NFS Server on localhost                     N/A       N/A        N       N/A  
NFS Server on 10.70.34.44                   N/A       N/A        N       N/A  
 
Task Status of Volume voly
------------------------------------------------------------------------------
There are no active volume tasks
 
[root@interstellar glusterfs]# gluster v attach-tier voly interstellar:/pavanbrick2/voly/hb1 transformers:/pavanbrick2/voly/hb1
volume add-brick: success
[root@interstellar glusterfs]# gluster v info voly
 
Volume Name: voly
Type: Tier
Volume ID: 22412494-df85-4458-a80f-0e4c0cc76572
Status: Started
Number of Bricks: 4 x 1 = 4
Transport-type: tcp
Bricks:
Brick1: transformers:/pavanbrick2/voly/hb1
Brick2: interstellar:/pavanbrick2/voly/hb1
Brick3: interstellar:/pavanbrick1/voly/b1
Brick4: transformers:/pavanbrick1/voly/b1
[root@interstellar glusterfs]# gluster v status voly
Status of volume: voly
Gluster process                             TCP Port  RDMA Port  Online  Pid
------------------------------------------------------------------------------
Brick transformers:/pavanbrick2/voly/hb1    49159     0          Y       32013
Brick interstellar:/pavanbrick2/voly/hb1    49159     0          Y       27567
Brick interstellar:/pavanbrick1/voly/b1     49158     0          Y       27482
Brick transformers:/pavanbrick1/voly/b1     49158     0          Y       31954
NFS Server on localhost                     N/A       N/A        N       N/A  
NFS Server on 10.70.34.44                   N/A       N/A        N       N/A  
 
Task Status of Volume voly
------------------------------------------------------------------------------
There are no active volume tasks
 
[root@interstellar glusterfs]# gluster v remove-brick voly transformers:/pavanbrick2/voly/hb1 force
Removing brick(s) can result in data loss. Do you want to Continue? (y/n) y
volume remove-brick commit force: success
[root@interstellar glusterfs]# gluster v status voly
Status of volume: voly
Gluster process                             TCP Port  RDMA Port  Online  Pid
------------------------------------------------------------------------------
Brick interstellar:/pavanbrick1/voly/b1     49158     0          Y       27482
Brick transformers:/pavanbrick1/voly/b1     49158     0          Y       31954
NFS Server on localhost                     N/A       N/A        N       N/A  
NFS Server on 10.70.34.44                   N/A       N/A        N       N/A  
 
Task Status of Volume voly
------------------------------------------------------------------------------
There are no active volume tasks
 
[root@interstellar glusterfs]# gluster v info voly
 
Volume Name: voly
Type: Tier
Volume ID: 22412494-df85-4458-a80f-0e4c0cc76572
Status: Started
Number of Bricks: 2 x 1 = 2
Transport-type: tcp
Bricks:
Brick1: interstellar:/pavanbrick1/voly/b1
Brick2: transformers:/pavanbrick1/voly/b1
[root@interstellar glusterfs]#

Comment 1 Nag Pavan Chilakam 2015-03-30 13:39:35 UTC

sosreports@rhsqe-repo:/home/repo/sosreports/1207238

Comment 2 Nag Pavan Chilakam 2015-03-30 13:40:21 UTC

Also, if you note, the remove brick even after acting like a detach tier, the volume type still remains as "tier"

Comment 3 Nag Pavan Chilakam 2015-04-20 05:43:42 UTC

As discussed with stakeholders,removing the tag for qe_tracker_everglades(bz#1186580)  for all add/remove brick issues

Comment 4 Mohammed Rafi KC 2015-04-23 11:45:18 UTC

upstream patch : http://review.gluster.org/#/c/10349/

Comment 5 Niels de Vos 2015-05-15 13:07:43 UTC

This change should not be in "ON_QA", the patch posted for this bug is only available in the master branch and not in a release yet. Moving back to MODIFIED until there is an beta release for the next GlusterFS version.

Comment 6 Amar Tumballi 2018-10-08 09:53:22 UTC

This bug was ON_QA status, and on GlusterFS product in bugzilla, we don't have that as a valid status. We are closing it as 'CURRENT RELEASE ' to indicate the availability of the fix, please reopen if found again.