Bug 1207257
| Summary: | changing the pinning with virsh setvcpupin does not work | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Peter Krempa <pkrempa> |
| Component: | libvirt | Assignee: | Peter Krempa <pkrempa> |
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 7.1 | CC: | dyuan, honzhang, jherrman, jsuchane, lhuang, mtessun, mzhan, rbalakri, virt-bugs |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | All | ||
| Whiteboard: | |||
| Fixed In Version: | libvirt-1.2.15-1.el7 | Doc Type: | Bug Fix |
| Doc Text: |
Previously, when the default CPU mask was specified while using Non-Uniform Memory Access (NUMA) pinning, virtual CPUs (vCPUs) could not be pinned to physical CPUs that were not contained in the default node mask. With this update, the control groups (cgroups) code correctly attaches only vCPU threads instead of the entire domain group, and using NUMA pinning with the default cpuset subsystem now works as expected.
|
Story Points: | --- |
| Clone Of: | 1198096 | Environment: | |
| Last Closed: | 2015-11-19 06:26:24 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1198096 | ||
| Bug Blocks: | |||
|
Description
Peter Krempa
2015-03-30 14:16:30 UTC
Fixed upstream:
commit f0fa9080d47b7aedad6f4884b8879d88688752a6
Author: Peter Krempa <pkrempa>
Date: Fri Mar 27 10:23:19 2015 +0100
qemu: cgroup: Properly set up vcpu pinning
When the default cpuset or automatic numa placement is used libvirt
would place the whole parent cgroup in the specified cpuset. This then
disallowed to re-pin the vcpus to a different cpu.
This patch pins only the vcpu threads to the default cpuset and thus
allows to re-pin them later.
The following config would fail to start:
<domain type='kvm'>
...
<vcpu placement='static' cpuset='0-1' current='2'>4</vcpu>
<cputune>
<vcpupin vcpu='0' cpuset='2-3'/>
...
This is a regression since a39f69d2b.
v1.2.14-4-gf0fa908
I can reproduce this issue with libvirt-1.2.13-1.el7.x86_64: 1. start a vm has cpuset like this: ... <vcpu placement='static' cpuset='0-1' current='2'>4</vcpu> ... 2. check the cgroup: # cgget -g cpuset /machine.slice/machine-qemu\\x2dtest3.scope /machine.slice/machine-qemu\x2dtest3.scope: cpuset.isolcpus: cpuset.memory_spread_slab: 0 cpuset.memory_spread_page: 0 cpuset.memory_pressure: 0 cpuset.memory_migrate: 0 cpuset.sched_relax_domain_level: -1 cpuset.sched_load_balance: 1 cpuset.mem_hardwall: 0 cpuset.mem_exclusive: 0 cpuset.cpu_exclusive: 0 cpuset.mems: 0 cpuset.cpus: 0-1 # cgget -g cpuset /machine.slice/machine-qemu\\x2dtest3.scope/vcpu0 /machine.slice/machine-qemu\x2dtest3.scope/vcpu0: cpuset.isolcpus: cpuset.memory_spread_slab: 0 cpuset.memory_spread_page: 0 cpuset.memory_pressure: 0 cpuset.memory_migrate: 0 cpuset.sched_relax_domain_level: -1 cpuset.sched_load_balance: 1 cpuset.mem_hardwall: 0 cpuset.mem_exclusive: 0 cpuset.cpu_exclusive: 0 cpuset.mems: 0 cpuset.cpus: 0-1 3. try to bind vcpu out of 0-1: # virsh vcpupin test3 1 2-3 error: Requested operation is not valid: failed to set cpuset.cpus in cgroup for vcpu 1 And verify this issue with libvirt-1.2.15-2.el7.x86_64: 1. start a vm has cpuset like this: ... <vcpu placement='static' cpuset='0-1' current='2'>4</vcpu> ... 2. check the cgroup: # cgget -g cpuset /machine.slice/machine-qemu\\x2dtest3.scope /machine.slice/machine-qemu\x2dtest3.scope: cpuset.isolcpus: 2-3 cpuset.memory_spread_slab: 0 cpuset.memory_spread_page: 0 cpuset.memory_pressure: 0 cpuset.memory_migrate: 1 cpuset.sched_relax_domain_level: -1 cpuset.sched_load_balance: 1 cpuset.mem_hardwall: 0 cpuset.mem_exclusive: 0 cpuset.cpu_exclusive: 0 cpuset.mems: 0 cpuset.cpus: 0-3 # cgget -g cpuset /machine.slice/machine-qemu\\x2dtest3.scope/vcpu0 /machine.slice/machine-qemu\x2dtest3.scope/vcpu0: cpuset.isolcpus: cpuset.memory_spread_slab: 0 cpuset.memory_spread_page: 0 cpuset.memory_pressure: 0 cpuset.memory_migrate: 1 cpuset.sched_relax_domain_level: -1 cpuset.sched_load_balance: 1 cpuset.mem_hardwall: 0 cpuset.mem_exclusive: 0 cpuset.cpu_exclusive: 0 cpuset.mems: 0 cpuset.cpus: 0-1 3. bind vcpu 1 out of 0-1: # virsh vcpupin test3 1 2-3 4. recheck the vcpupin and cgroup: # virsh vcpupin test3 VCPU: CPU Affinity ---------------------------------- 0: 0-1 1: 2-3 # cgget -g cpuset /machine.slice/machine-qemu\\x2dtest3.scope/vcpu1 /machine.slice/machine-qemu\x2dtest3.scope/vcpu1: cpuset.isolcpus: 2-3 cpuset.memory_spread_slab: 0 cpuset.memory_spread_page: 0 cpuset.memory_pressure: 0 cpuset.memory_migrate: 1 cpuset.sched_relax_domain_level: -1 cpuset.sched_load_balance: 1 cpuset.mem_hardwall: 0 cpuset.mem_exclusive: 0 cpuset.cpu_exclusive: 0 cpuset.mems: 0 cpuset.cpus: 2-3 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-2202.html |