Bug 1207393

Summary: Add support for configuration options to rhq-server.properites for RequestLimit, RequestLimitTopologyChange, Warmup period, Warmup Counter Maximum
Product: [JBoss] JBoss Operations Network Reporter: Michael Burman <miburman>
Component: Configuration, Storage NodeAssignee: Simeon Pinder <spinder>
Status: CLOSED ERRATA QA Contact: Filip Brychta <fbrychta>
Severity: high Docs Contact:
Priority: high    
Version: JON 3.3.2CC: fbrychta, loleary, mfoley, rhatlapa, spinder
Target Milestone: ER01   
Target Release: JON 3.3.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-04-30 16:11:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1207394    

Description Michael Burman 2015-03-30 20:03:48 UTC
Description of problem: The Storage Client Subsystem on the RHQ Server EAP should show "RequestLimit", "RequestLimitTopologyChange", "Warmup period" and "Warmup Counter Maximum" but it shows the old information. This means it is missing one cherry-pick that would fix the UI.


Version-Release number of selected component (if applicable):


How reproducible: Always


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Michael Burman 2015-03-31 08:09:45 UTC
The missing commit is the following one:

commit e8a902ed399920177c2cb2bf4801be7ca61309ba
Author: Michael Burman <miburman>
Date:   Wed Jan 7 14:53:30 2015 +0200

    [BZ 1098243] Remove redundant request limit configuration options and make the warmup periods configurable through the UI

Libor, will you pick?

Comment 2 Michael Burman 2015-03-31 08:18:15 UTC
Also in the master, a small bug I found which should be cherry-picked after the previous one.

commit 16d26b405643ebfb0920f989f73c2bf383478655
Author: Michael Burman <miburman>
Date:   Tue Mar 31 11:17:02 2015 +0300

    [BZ 1207393] MaxWarmupCounter is not editable through the UI

(it called the wrong method in StorageSession)

Comment 3 Libor Zoubek 2015-04-01 17:34:10 UTC
$ git cherry-pick e8a902ed399920177c2cb2bf4801be7ca61309ba

is telling me the commit is empty - this means it *was* cherry-picked https://github.com/rhq-project/rhq/commit/a8cbf18cf25eb8dfa20886ebc5b7dcc40ce5d06b

branch:  release/jon3.3.x
link:    https://github.com/rhq-project/rhq/commit/f7877ef9e
time:    2015-04-01 19:33:49 +0200
commit:  f7877ef9e918dcc1693dcd8e7354e5d3ef00bdb9
author:  Michael Burman - miburman
message: [BZ 1207393] MaxWarmupCounter is not editable through the UI
         (cherry picked from commit
         16d26b405643ebfb0920f989f73c2bf383478655) Signed-off-by: Libor
         Zoubek <lzoubek>

Comment 4 Simeon Pinder 2015-04-13 04:14:42 UTC
Moving to ON_QA for testing with latest cumulative patch build:
https://brewweb.devel.redhat.com//buildinfo?buildID=429507

Note: Build maps to JON 3.3.2 ER01 build.

Comment 5 Filip Brychta 2015-04-14 12:03:53 UTC
The change is still not visible in ER01 (3.3.0.GA Update 02 Build Number : 0b1f2c5:9451566)

@Simeon - The change should be in rhq-rhqserver-plugin-4.12.0.JON330GA.jar, is this part of ER01 or this bz should be targeted as One-off?

Comment 9 Mike Foley 2015-04-16 12:55:36 UTC
rejected by qe in jon 3.3.2 er1.  setting target to cr1 for now

Comment 11 Filip Brychta 2015-04-20 17:01:55 UTC
Verified on JON3.3.2.ER01

Verified via jconsole that given properties were set according to rhq-server.properties. When unset, defaults were used.

Comment 13 errata-xmlrpc 2015-04-30 16:11:20 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0920.html