Bug 1207566
Summary: | Should change the "bond_setup" to "bond" in /usr/libexec/ovirt-init-functions.sh | ||
---|---|---|---|
Product: | Red Hat Enterprise Virtualization Manager | Reporter: | wanghui <huiwa> |
Component: | ovirt-node | Assignee: | Douglas Schilling Landgraf <dougsland> |
Status: | CLOSED ERRATA | QA Contact: | wanghui <huiwa> |
Severity: | low | Docs Contact: | |
Priority: | low | ||
Version: | 3.5.1 | CC: | cshao, dougsland, fdeutsch, gklein, huiwa, leiwang, lsurette, rbarry, yaniwang, ycui, ykaul |
Target Milestone: | ovirt-3.6.0-rc | ||
Target Release: | 3.6.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | ovirt-node-3.3.0-0.4.20150906git14a6024.el7ev | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-03-09 14:20:46 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | Node | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
wanghui
2015-03-31 08:09:59 UTC
IIUIC this is only about a updating a source code comment. Test version: rhev-hypervisor7-7.2-20151025.0.el7ev ovirt-node-3.3.0-0.18.20151022git82dc52c.el7ev.noarch Test steps: 1. Install rhev-hypervisor7-7.2-20151025.0.el7ev 2. Check the auto installation parameters in /usr/libexec/ovirt-init-functions.sh Actual results: 1. It shows bond parameters as follows. # bond_setup=<bondname>:<bondslave,bondslave>:[:<option_arg,option_arg>] # Use bond for node based on RHEL/CentOS 7 or higher # Use bond_setup for node based on RHEL/CentOS 6 But as the merged patch shows it should change to "bond or bond_setup=<bondname>:<bondslaves>:[:<options>]" which is difference. Hi Douglas, I want to check with you that is there any changes after the patch merged? If also, I'd like to change the "bond_setup=" to "bond or bond_setup=" to make that more clear. Thanks, Hui Wang (In reply to wanghui from comment #3) > Test version: > rhev-hypervisor7-7.2-20151025.0.el7ev > ovirt-node-3.3.0-0.18.20151022git82dc52c.el7ev.noarch > > Test steps: > 1. Install rhev-hypervisor7-7.2-20151025.0.el7ev > 2. Check the auto installation parameters in > /usr/libexec/ovirt-init-functions.sh > > Actual results: > 1. It shows bond parameters as follows. > # bond_setup=<bondname>:<bondslave,bondslave>:[:<option_arg,option_arg>] > # Use bond for node based on RHEL/CentOS 7 or higher > # Use bond_setup for node based on RHEL/CentOS 6 > > But as the merged patch shows it should change to "bond or > bond_setup=<bondname>:<bondslaves>:[:<options>]" which is difference. > > Hi Douglas, > > I want to check with you that is there any changes after the patch merged? > If also, I'd like to change the "bond_setup=" to "bond or bond_setup=" to > make that more clear. > I see this patch https://gerrit.ovirt.org/#/c/33348/ got merged after. Ryan, what do you think about Wanghui comment#3? Thanks! I have no qualms with changing the comment back, as long as it's clear which one should be used on EL6, and which on EL7 According to comment#5, the expected change should be as follows. # bond_setup=<bondname>:<bondslave,bondslave>:[:<option_arg,option_arg>] # Use bond for node based on RHEL/CentOS 7 or higher # Use bond_setup for node based on RHEL/CentOS 6 Verified this issue on rhev-hypervisor7-7.2-20151112.1.el7ev(ovirt-node-3.6.0-0.20.20151103git3d3779a.el7ev.noarch). Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-0378.html |