Bug 1207709

Summary:	trash: remove_trash_path broken in the internal case
Product:	[Community] GlusterFS	Reporter:	Michael Adam <madam>
Component:	trash-xlator	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	mainline	CC:	bugs, gluster-bugs, rkavunga
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-05-14 17:29:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michael Adam 2015-03-31 14:11:03 UTC

Description of problem:

Code inspection of the xlators/features/trash module showed that
that function remove_trash_path() does not do what it is supposed
to do.

1) Firstly, since the rem_path variable is not handed in by
   reference, the desired effect to the caller does not happen
   at all. This bug is fixed by:
   http://review.gluster.org/#/c/10064/
   (tracked as Coverity fix in bug #789278)

2) On top of that, the actual issue of this defect:
   The current code does the exact same thing in the
   cases internal == true and internal == false.
   What it is supposed to do is to remove an extra
   path component in the internal case (the "internal_op/"
   one added in the internal case by copy_trash_path().

Comment 1 Anand Avati 2015-03-31 14:16:26 UTC

REVIEW: http://review.gluster.org/10073 (features/trash: fix remove_trash_path in the internal case) posted (#1) for review on master by Michael Adam (obnox)

Comment 2 Anand Avati 2015-04-01 06:52:08 UTC

COMMIT: http://review.gluster.org/10073 committed in master by Vijay Bellur (vbellur) 
------
commit ef5c3182224940f76d9290c1c4d9cc8e78fbdb83
Author: Michael Adam <obnox>
Date:   Tue Mar 31 13:47:21 2015 +0200

    features/trash: fix remove_trash_path in the internal case
    
    In the internal case, copy_trash_path adds a second
    path component "internal_op/", so remove_trash_path
    should remove it again. Originally, remove_trash_path
    did the same thing in the internal and non-internal case.
    This patch fixes this problem.
    
    Change-Id: If247d18217a2375d369672182f69a54881df26b9
    BUG: 1207709
    Signed-off-by: Michael Adam <obnox>
    Reviewed-on: http://review.gluster.org/10073
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anoop C S <achiraya>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 3 Niels de Vos 2015-05-14 17:29:25 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 4 Niels de Vos 2015-05-14 17:35:55 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Niels de Vos 2015-05-14 17:38:17 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:46:38 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user