Bug 1208381
| Summary: | Review Request: gmavenplus-plugin - Integrates Groovy into Maven projects | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | gil cattaneo <puntogil> | ||||||||
| Component: | Package Review | Assignee: | Mukundan Ragavan <nonamedotc> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | rawhide | CC: | nonamedotc, package-review, projects.rg | ||||||||
| Target Milestone: | --- | Flags: | nonamedotc:
fedora-review+
|
||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2016-03-17 20:52:07 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 1251207 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
gil cattaneo
2015-04-02 06:46:07 UTC
Spec URL: https://gil.fedorapeople.org/gmavenplus-plugin.spec SRPM URL: https://gil.fedorapeople.org/gmavenplus-plugin-1.5-1.fc22.src.rpm Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10703206 Spec URL: https://gil.fedorapeople.org/gmavenplus-plugin.spec SRPM URL: https://gil.fedorapeople.org/gmavenplus-plugin-1.5-1.fc23.src.rpm gil's scratch build of gmavenplus-plugin-1.5-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13249054 Created attachment 1133532 [details]
review.txt
LGTM, please approve
Created attachment 1133533 [details]
licensecheck.txt
[?]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)", "Unknown or generated". 25 files have unknown
license. Detailed output of licensecheck in /home/builder/fedora-
review/1208381-gmavenplus-plugin/licensecheck.txt
=> Some source files without license header, please validate. See also below.
Only one file: GMavenPlus-1.5/src/main/java/org/codehaus/gmavenplus/plexus/AbstractIncludeProjectDependenciesComponentConfigurator.java
Open https://github.com/groovy/GMavenPlus/issues/50
[?]: Package contains no bundled libraries without FPC exception.
=> I assume the src/it and src/main folders only are relevant for built jar.
Only src/main/java the rest is not involved
[?]: Package functions as described.
=> OK, all provided and enabled tests pass. Can't tell about UAT.
Sorry, I don't understand the meaning of "UAT"
gmavenplus-plugin.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/gmavenplus-plugin/README.markdown
Fixed
> Sorry, I don't understand the meaning of "UAT" http://www.techopedia.com/definition/3887/user-acceptance-testing-uat http://www.softwaretestinghelp.com/what-is-user-acceptance-testing-uat etc. Created attachment 1133565 [details]
build.log
Thanks Raphael for the excellent work!
---> review.txt as done by raphael looks fine by me. I do not have additional concerns.
---> license situation is addressed as such
---> tests are run and all seem to pass without issues.
---> build.log is attached. Everything seems fine there.
Everything looks fine to me. Package APPROVED. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/gmavenplus-plugin gmavenplus-plugin-1.5-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b73e30bc77 gmavenplus-plugin-1.5-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b73e30bc77 gmavenplus-plugin-1.5-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |