Bug 1208698

Summary: Add new D2 instance types for Amazon EC2
Product: Red Hat CloudForms Management Engine Reporter: Jason Frey <jfrey>
Component: ProvidersAssignee: Greg Blomquist <gblomqui>
Status: CLOSED ERRATA QA Contact: Ramesh A <rananda>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 5.4.0CC: gblomqui, jfrey, jhardy, obarenbo, rananda
Target Milestone: GA   
Target Release: 5.4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1209168 (view as bug list) Environment:
Last Closed: 2015-06-16 12:56:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1209168    
Attachments:
Description Flags
D2 instance types not available none

Description Jason Frey 2015-04-02 22:20:41 UTC
Description of problem:

Amazon has added 4 new instance types called D2, and deprecated the 1 HS1 instance type.


Version-Release number of selected component (if applicable):

All versions

Comment 2 CFME Bot 2015-04-07 17:15:52 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/e2409db0ec2ca04e34b472fe45590a84efb39d17

commit e2409db0ec2ca04e34b472fe45590a84efb39d17
Author:     Jason Frey <jfrey>
AuthorDate: Thu Apr 2 17:55:58 2015 -0400
Commit:     Jason Frey <jfrey>
CommitDate: Mon Apr 6 11:22:37 2015 -0400

    Add new Amazon D2 instance types and deprecate the HS1 instance type.
    
    Fixes #2477
    https://bugzilla.redhat.com/show_bug.cgi?id=1208698

 lib/Amazon/MiqEc2InstanceTypes.rb                  | 124 ++++++++++++++++++---
 .../refreshers/ec2_refresher_other_region_spec.rb  |   4 +-
 .../ems_refresh/refreshers/ec2_refresher_spec.rb   |   4 +-
 3 files changed, 112 insertions(+), 20 deletions(-)

Comment 3 CFME Bot 2015-04-07 21:10:52 UTC
New commit detected on cfme/5.3.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=adcb8a77598b0c946cc190307945e07bca89560f

commit adcb8a77598b0c946cc190307945e07bca89560f
Author:     Jason Frey <jfrey>
AuthorDate: Thu Apr 2 17:55:58 2015 -0400
Commit:     Jason Frey <jfrey>
CommitDate: Tue Apr 7 14:01:44 2015 -0400

    Add new Amazon D2 instance types and deprecate the HS1 instance type.
    
    Fixes #2477
    https://bugzilla.redhat.com/show_bug.cgi?id=1208698
    https://bugzilla.redhat.com/show_bug.cgi?id=1209168
    
    Conflicts:
    	vmdb/spec/models/ems_refresh/refreshers/ec2_refresher_spec.rb

 lib/Amazon/MiqEc2InstanceTypes.rb                  | 124 ++++++++++++++++++---
 .../refreshers/ec2_refresher_other_region_spec.rb  |   4 +-
 .../ems_refresh/refreshers/ec2_refresher_spec.rb   |   4 +-
 3 files changed, 112 insertions(+), 20 deletions(-)

Comment 4 CFME Bot 2015-04-07 21:10:59 UTC
New commit detected on cfme/5.3.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=1cac43a24c8e95ffc81ce5440d7ffb1673c90d14

commit 1cac43a24c8e95ffc81ce5440d7ffb1673c90d14
Merge: ac014c0 adcb8a7
Author:     Brandon Dunne <bdunne>
AuthorDate: Tue Apr 7 17:09:43 2015 -0400
Commit:     Brandon Dunne <bdunne>
CommitDate: Tue Apr 7 17:09:43 2015 -0400

    Merge branch '5.3.z-add_new_ec2_instances' into '5.3.z'
    
    5.3.z: Add new Amazon D2 instance types and deprecate the HS1 instance type
    
    Upstream merged PR: https://github.com/ManageIQ/manageiq/pull/2514
    
    Also had to copy in the changes in https://github.com/ManageIQ/manageiq/pull/745, so that there would not be conflicts/errors when bringing in the new instance types.
    
    Note that there were conflicts on the cherry-pick, but those were spec only, and are because OrchestrationStack* was added to the upstream tests.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1208698
    https://bugzilla.redhat.com/show_bug.cgi?id=1209168
    
    This also has to go to 5.3.4, which I'll make an MR for.
    
    See merge request !26

 lib/Amazon/MiqEc2InstanceTypes.rb                  | 178 ++++++++++++++++++---
 vmdb/app/models/ems_refresh/parsers/ec2.rb         |   6 +-
 .../refreshers/ec2_refresher_other_region_spec.rb  |   4 +-
 .../ems_refresh/refreshers/ec2_refresher_spec.rb   |   4 +-
 4 files changed, 161 insertions(+), 31 deletions(-)

Comment 5 CFME Bot 2015-04-07 21:35:30 UTC
New commit detected on cfme/5.3.4:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=71f5a05a000fce1ba87a9fa1150e9b1c29c0e60f

commit 71f5a05a000fce1ba87a9fa1150e9b1c29c0e60f
Author:     Jason Frey <jfrey>
AuthorDate: Thu Apr 2 17:55:58 2015 -0400
Commit:     Jason Frey <jfrey>
CommitDate: Tue Apr 7 14:08:59 2015 -0400

    Add new Amazon D2 instance types and deprecate the HS1 instance type.
    
    Fixes #2477
    https://bugzilla.redhat.com/show_bug.cgi?id=1208698
    https://bugzilla.redhat.com/show_bug.cgi?id=1209168
    
    Conflicts:
    	vmdb/spec/models/ems_refresh/refreshers/ec2_refresher_spec.rb

 lib/Amazon/MiqEc2InstanceTypes.rb                  | 124 ++++++++++++++++++---
 .../refreshers/ec2_refresher_other_region_spec.rb  |   4 +-
 .../ems_refresh/refreshers/ec2_refresher_spec.rb   |   4 +-
 3 files changed, 112 insertions(+), 20 deletions(-)

Comment 7 Ramesh A 2015-04-22 13:08:05 UTC
Not available in  5.4.0.0.22.20150420163946_26004d1.  Is it cherry picked in the latest build??

Comment 8 Jason Frey 2015-04-22 13:42:24 UTC
According to the git tree, this should have been in since 5.4.0.0-beta2

Comment 9 Ramesh A 2015-04-22 14:21:16 UTC
Verification failed.  Not able to see D2 instance types and HS1 still present in 5.4.0.0.22.20150420163946_26004d1.  

Refer the screenshot for further details.

Comment 10 Ramesh A 2015-04-22 14:22:21 UTC
Created attachment 1017478 [details]
D2 instance types not available

Comment 11 Jason Frey 2015-04-22 20:31:18 UTC
Ramesh, you have to refresh the EMS before they will be available.  Can you verify they are available after refresh?

Comment 12 Ramesh A 2015-04-23 16:31:17 UTC
Good to go.  Verified and working fine in 5.4.0.0.22.20150420163946_26004d1.  Now appliance displays the below mentioned D2 instances for HMV ami's.

d2.xlarge: D2 Extra Large
d2.2xlarge: D2 Double Extra Large
d2.4xlarge: D2 Quadruple Extra Large
d2.8xlarge: D2 Eight Extra Large

Comment 14 errata-xmlrpc 2015-06-16 12:56:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html