Bug 1209019

Summary: Missing default login shell for new users
Product: [Fedora] Fedora Reporter: Germano Massullo <germano.massullo>
Component: kuserAssignee: Rex Dieter <rdieter>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: low    
Version: 23CC: jgrulich, kevin, mbriza, mike, rdieter, than
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: kuser-16.04.0-2.fc23 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-26 20:53:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Germano Massullo 2015-04-05 09:22:56 UTC
Description of problem:
If you add a new user and you don't pay attention to setting a login shell, when you will try logging in ssdm, you will get a black X screen

Version-Release number of selected component (if applicable):
3.9

Comment 1 Germano Massullo 2015-07-15 12:36:16 UTC
Confirming on Plasma 5

Comment 2 Rex Dieter 2015-07-15 13:51:51 UTC
I'd reocmmend reporting this upstream @ bugs.kde.org

Comment 3 Mike Goodwin 2016-04-23 14:09:18 UTC
(In reply to Rex Dieter from comment #2)
> I'd reocmmend reporting this upstream @ bugs.kde.org

I would imagine upstream has left this by default as to allow the package maintainer to set it for their distro? Especially since the only thing in the README espouses that it was written for different platforms like Solaris, FreeBSD, etc. 

I'm not even sure why kuser.kcfg is being installed as part of the package? It's a build time configuration that is compiled by `kconfig_compiler4` and then never touched by the program itself (I checked with strace -e open) 

To fix the problem the following file must be edited: 


@@ -35,6 +35,7 @@
     <entry name="shell" type="String">
       <label>Shell</label>
       <whatsthis>This option allows you to select the shell which will be the default for new users.</whatsthis>
+      <default>/bin/bash</default>
     </entry>
     <entry name="homepath" type="String">
       <label>Home path template</label>


Which is then compiled and results in the following (during the build): 


ku_prefs.cpp:  itemShell = new KConfigSkeleton::ItemString( currentGroup(), QLatin1String( "shell" ), mShell, QLatin1String( "/bin/bash" ) );


I have built with the following and confirmed that when doing so, a default shell is configured properly if one is not already present. 

Again, I'm not sure why this is being included with the package install either:


%{_kde4_datadir}/config.kcfg/%{name}.kcfg


can you explain? 

It's my opinion that the policy for this package should be that the maintainer synchronizes the defaults in kuser.kcfg with /etc/default/useradd, so that there are no disparities between someone creating a user with either. (Yes I understand that they could diverge if someone configured one and not the other, but we're after sane defaults no?)

Comment 4 Rex Dieter 2016-04-23 14:33:20 UTC
Comment #3 looks lovely, something we can certainly adopt, I'll look into it.

Comment 5 Fedora Update System 2016-04-23 20:40:22 UTC
ksystemlog-16.04.0-1.fc24 kcron-16.04.0-1.fc24 kuser-16.04.0-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-faf7cca741

Comment 6 Fedora Update System 2016-04-23 20:41:17 UTC
kuser-16.04.0-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ed48efbccf

Comment 7 Fedora Update System 2016-04-23 20:41:47 UTC
kuser-16.04.0-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9edd86eb1a

Comment 8 Fedora Update System 2016-04-24 01:24:15 UTC
kcron-16.04.0-1.fc24, ksystemlog-16.04.0-1.fc24, kuser-16.04.0-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-faf7cca741

Comment 9 Fedora Update System 2016-04-24 06:22:38 UTC
kuser-16.04.0-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ed48efbccf

Comment 10 Fedora Update System 2016-04-24 06:25:46 UTC
kuser-16.04.0-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9edd86eb1a

Comment 11 Fedora Update System 2016-04-26 20:53:26 UTC
kuser-16.04.0-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2016-05-03 09:49:51 UTC
kuser-16.04.0-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2016-05-07 11:58:13 UTC
kcron-16.04.0-1.fc24, ksystemlog-16.04.0-1.fc24, kuser-16.04.0-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.