Bug 1209408
| Summary: | [Snapshot] Scheduler should accept only valid crond schedules | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Anil Shah <ashah> |
| Component: | snapshot | Assignee: | Avra Sengupta <asengupt> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | urgent | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | mainline | CC: | asengupt, bugs, gluster-bugs, nsathyan, senaik |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.7.0beta1 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-05-14 17:27:15 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1186580 | ||
|
Description
Anil Shah
2015-04-07 10:06:40 UTC
Version: ======== gluster --version glusterfs 3.7dev built on Apr 9 2015 01:10:22 Currently while adding jobs, when schedule is not provided, it successfully adds it and the job can be listed. [root@inception ~]# snap_scheduler.py add "J2" " " "vol0" snap_scheduler: Successfully added snapshot schedule [root@inception ~]# snap_scheduler.py list JOB_NAME SCHEDULE OPERATION VOLUME NAME -------------------------------------------------------------------- J1 */30 * * * * Snapshot Create vol0 J2 Snapshot Create vol0 It should error out with message : snap_scheduler: Invalid Schedule. Schedule should not be empty and should not contain " " character. REVIEW: http://review.gluster.org/10169 (snapshot/scheduler: Validate the number of entries in schedule) posted (#1) for review on master by Avra Sengupta (asengupt) REVIEW: http://review.gluster.org/10169 (snapshot/scheduler: Validate the number of entries in schedule) posted (#2) for review on master by Avra Sengupta (asengupt) COMMIT: http://review.gluster.org/10169 committed in master by Krishnan Parthasarathi (kparthas) ------ commit 10ed06a5a1ec396bb8fc7cc1fa8182d93bf7dbb5 Author: Avra Sengupta <asengupt> Date: Thu Apr 9 14:58:25 2015 +0530 snapshot/scheduler: Validate the number of entries in schedule A valid schedule entry in snapshot schedule must have six elements and adhere to the following format * * * * * | | | | | | | | | +---- Day of the Week (range: 1-7, 1 standing for Monday) | | | +------ Month of the Year (range: 1-12) | | +-------- Day of the Month (range: 1-31) | +---------- Hour (range: 0-23) +------------ Minute (range: 0-59) Change-Id: Idf03a3c43a461295dd3e2026bbcd0420319dd0e0 BUG: 1209408 Signed-off-by: Avra Sengupta <asengupt> Reviewed-on: http://review.gluster.org/10169 Reviewed-by: Aravinda VK <avishwan> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Krishnan Parthasarathi <kparthas> Tested-by: Krishnan Parthasarathi <kparthas> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report. glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report. glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report. glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |