Bug 1209809

Summary: Review Request: rubyripper - cdparanoia based high quality cd ripper
Product: [Fedora] Fedora Reporter: Benjamin <Benjamin>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: package-review, rosser.bjr
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-11-20 13:46:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 177841, 201449    

Description Benjamin@BGRoberts.id.au 2015-04-08 09:14:57 UTC
Spec URL: https://github.com/tsujamin/benjamin-rpmbuild/blob/master/SPECS/rubyripper.spec
SRPM URL: https://github.com/tsujamin/benjamin-rpmbuild/releases/download/rubyripper-0.6.1/rubyripper-0.6.1-1.fc21.src.rpm
Description: "Rubyripper aims to deliver high quality rips from audio cd's to your computer drive. It tries to do so by ripping the same track with cdparanoia multiple times and then comparing the results. It currently has a gtk2 and a command-line interface."
Fedora Account System Username: benjaminroberts

The package's upstream maintainer is no longer active in the project, so, along with my recent patches, I'd like to take over and hopefully have it included as a Fedora package.

Builds under mock and koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=9434981

Comment 1 Till Hofmann 2015-08-24 18:33:53 UTC
I just had a quick look at the Spec file. Some comments:

Please post a link to the raw Spec file, otherwise various tools won't work. Github supports raw links, e.g. [1]. You could also request webspace at fedorapeople.org.

Are you already a packager? If not, you need to block FE-NEEDSPONSOR, see [2] and [3] for details.

The License tag should be GPLv3+, because all files are licensed under "GPLv3 or later".

The changelog is not in the correct format, see [4] for the correct Changelog format.


[1] https://raw.githubusercontent.com/tsujamin/benjamin-rpmbuild/master/SPECS/rubyripper.spec
[2] https://fedoraproject.org/wiki/How_to_create_an_RPM_package
[3] https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
[4] https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

Comment 2 Benjamin@BGRoberts.id.au 2015-08-25 02:19:30 UTC
Spec URL: https://raw.githubusercontent.com/tsujamin/benjamin-rpmbuild/master/SPECS/rubyripper.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/5411/10815411/rubyripper-0.6.1-1.fc22.src.rpm
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10815411

I've updated those issues in the spec file.

I am not currently a packager, so I've added the FE-NEEDSPONSOR block and am sending an email into devel.org

Comment 3 Ben Rosser 2019-09-11 14:54:52 UTC
Hi,

I'm very sorry this has sat in the queue for so long-- unfortunately sometimes things get overlooked. :(

Are you still interested in this package and becoming a packager? I'd be happy to review it and sponsor you.

Comment 4 Benjamin@BGRoberts.id.au 2019-11-20 03:00:42 UTC
No problem! From memory there’s some additional problems with the package now, and I’m not working as frequently on Fedora so probably don’t have the requisite attention to maintain the package. Thanks for the offer and should I move back to using this package I’ll resubmit.

Comment 5 Ben Rosser 2019-11-20 13:46:14 UTC
Understood. I'll close this ticket out, then-- feel free to open a new one in the future.