Bug 1209869

Summary:	xdata in FOPs should always be valid and never junk
Product:	[Community] GlusterFS	Reporter:	Raghavendra Talur <rtalur>
Component:	core	Assignee:	Raghavendra Talur <rtalur>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, sankarshan
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-16 12:48:36 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Raghavendra Talur 2015-04-08 11:27:12 UTC

Description of problem:

As discussed on gluster-devel http://www.gluster.org/pipermail/gluster-devel/2015-April/044307.html , we should always have a valid xdata in FOPs.

This requires fixes in places where
1. xdata is left out and not passed when a error is hit and op_ret is < 0.
2. xdata pointing to junk should be set to NULL in error cases.(not sure if any exist)

Comment 1 Anand Avati 2015-04-10 08:37:20 UTC

REVIEW: http://review.gluster.org/10189 (libglusterfs: Pass xdata in all cases) posted (#1) for review on master by Raghavendra Talur (rtalur)

Comment 2 Anand Avati 2015-04-10 10:28:54 UTC

REVIEW: http://review.gluster.org/10193 (libglusterfs/syncop: Pass xdata even in error case) posted (#1) for review on master by Raghavendra Talur (rtalur)

Comment 3 Anand Avati 2015-04-27 07:09:52 UTC

COMMIT: http://review.gluster.org/10193 committed in master by Vijay Bellur (vbellur) 
------
commit 3e1dbb49624f4dc430e0c6e7f4626bdf6f84120b
Author: Raghavendra Talur <rtalur>
Date:   Fri Apr 10 15:54:27 2015 +0530

    libglusterfs/syncop: Pass xdata even in error case
    
    xdata should be passed even in error cases.
    lookup() call was missed in previous patch set.
    
    Change-Id: I1ad2c452d05a3b4433b640762aaea5d3a91f2ba5
    BUG: 1209869
    Signed-off-by: Raghavendra Talur <rtalur>
    Reviewed-on: http://review.gluster.org/10193
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 4 Anand Avati 2015-04-27 07:40:55 UTC

REVIEW: http://review.gluster.org/10189 (libglusterfs: Pass xdata in all cases) posted (#2) for review on master by Raghavendra Talur (rtalur)

Comment 5 Mike McCune 2016-03-28 23:30:47 UTC

This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 6 Niels de Vos 2016-06-16 12:48:36 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user