Bug 1210181

Summary:	Unable to apply a patch to not yet installed server when there is co-located previous JON installation
Product:	[JBoss] JBoss Operations Network	Reporter:	Filip Brychta <fbrychta>
Component:	Installer, Launch Scripts, Upgrade	Assignee:	Simeon Pinder <spinder>
Status:	CLOSED ERRATA	QA Contact:	Filip Brychta <fbrychta>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	JON 3.3.0	CC:	loleary
Target Milestone:	DR01	Keywords:	Triaged
Target Release:	JON 3.3.3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-08-07 07:43:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Filip Brychta 2015-04-09 06:48:13 UTC

Description of problem:


Version-Release number of selected component (if applicable):
JON3.3.2.DR01

How reproducible:
Always

Steps to Reproduce:
1. install JON 3.2.0.GA
2. stop all components
3. download and unzip JON3.3.0.GA and JON3.3.2.DR01 patch
4. jon-server-3.3.0.GA-update-02/apply-updates.sh jon-server-3.3.0.GA

Actual results:
No jon java process is running but the patch fails with:

Testing for INSTALL_PATCH_DEST[JON Server|JON agent] directory.
	Successfully detected server [jon-server-3.3.0.GA] to be upgraded. Proceeding...
	Proceeding with application of patch '02' to jon-server-3.3.0.GA
	Checking [Server] file permissions...
	Verifying that all [Server] component(s) are stopped...
	Unable to apply patch as [Server] component(s) may still be running. Retrying...
	Unable to apply patch as [Server] component(s) may still be running. Retrying...
	Unable to apply patch as [Server] component(s) may still be running. Retrying...
	Unable to apply patch as [Server] component(s) may still be running. Retrying...
	Unable to apply patch as [Server] component(s) may still be running. Retrying...
	Unable to apply patch as [Server] component(s) may still be running. Retrying...
	The [Server] or one of it's components may still be running.
	See jon-server-3.3.0.GA/.patched/3.3.0.GA-update-02_04-09-15_02-39-29/status.log for more details.
	Shut down [Server] before applying Update 02.
	Update NOT applied. Exiting...


Expected results:
The patch should be applied

Additional info:
It works on clean environment (without JON3.2.0.GA being installed).
So when you remove old JON3.2.0 with it's agent the patch is then applied so it's somehow related to existence of JON3.2.0.GA installation.
When you do the upgrade first and then apply the patch, it's working.

Comment 1 Filip Brychta 2015-04-17 06:11:21 UTC

Setting to 3.3.3 for proper triage. Applying the 3.3.2 update to a 3.3 server
before it has been properly installed/upgraded (rhqctl install or rhqctl
upgrade) will not be supported in 3.3.2. We will try to get this in/working in
3.3.3.

Comment 2 Simeon Pinder 2015-06-08 16:34:39 UTC

This is fixed with the following commit to release/jon3.3.x.

commit 4c89e3701c0cf98e8ea131689c364d89fa7e0012
[BZ 1210181] tighten up running services check to better distinguish consol
        for 3.2 and later.

The issue was that the messages generated by rhqctl with status checks changed between JON 3.2 and JON 3.3.  Additional console symbols/encodings were added in
JON 3.3.  The fix was to make the check for 3.3 specific enough to no longer be mistakenly confused with 3.2.x status messages.

Moving to MODIFIED.

Comment 3 Simeon Pinder 2015-06-08 20:53:21 UTC

Moving to ON_QA for testing with latest brew build:

https://brewweb.devel.redhat.com/buildinfo?buildID=439630
* Maps to 3.3.3 DR01 build.

Comment 4 Filip Brychta 2015-06-10 14:56:22 UTC

Verified on
Version :	
3.3.0.GA Update 03
Build Number :	
82ad0cc:a25836e