Bug 1210254

Summary:	re-using partitions inside LUKS automatically checked for encryption
Product:	[Fedora] Fedora	Reporter:	Branko Grubić <bitlord0xff>
Component:	anaconda	Assignee:	Vratislav Podzimek <vpodzime>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	22	CC:	anaconda-maint-list, awilliam, g.kaviyarasu, jonathan, pschindl, robatino, travneff, vanmeeuwen+fedora, vpodzime
Target Milestone:	---	Keywords:	CommonBugs
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	RejectedBlocker AcceptedFreezeException https://fedoraproject.org/wiki/Common_F22_bugs#existing-luks-lvm
Fixed In Version:	libblockdev-0.11-1.fc22	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-04-29 12:57:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1043132

Description Branko Grubić 2015-04-09 09:48:43 UTC

Description of problem:
I have older system which I wanted to "upgrade"/clean install+keeping /home,

/dev/sda
- sda1, /boot (ext4)
- sda2, LUKS
 - LVM_PV
  - lv_swap
  - lv_root
  - lv_home

I used anaconda to unlock LUKS, it recognized old system, and all partitions, I set mount point for /home without formatting, formated /dev/sda1 and set /boot mountpoint, for root, and swap when I selected to format them, and set mountpoint, anaconda automatically checks "encrypt" checkbox, and later asks for passphrase.

Version-Release number of selected component (if applicable):
I used beta-tc8 (which is the same as tc7) uses python-blivet-1.0.6-1.fc22,anaconda-22.20.8-1.fc22 (copied from rel-eng trac)

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Vratislav Podzimek 2015-04-09 11:04:51 UTC

I can confirm this is easily reproducible. The result is that not only Anaconda asks for a new passphrase it actually creates LUKS devices (on LVs) for all mountpoints that originally were on the encrypted LUKS.

Comment 2 Adam Williamson 2015-04-09 15:43:27 UTC

I feel like I've seen another report of this, too?

This feels Final blocker-ish, under our 'awesome' Final criterion (no, really, it's horrible):

https://fedoraproject.org/wiki/Fedora_22_Final_Release_Criteria#Disk_layouts

"The installer must be able to create and install to any workable partition layout using any file system and/or container format combination offered in a default installer configuration."

wdyt, vpod?

Comment 3 Vratislav Podzimek 2015-04-10 07:51:55 UTC

Well, in the case the installer is able to create and install to it, but the result is not what the user would expect. bitlord reported some further issues with this that might be better suited for final blocker criteria, but I don't have the descriptions available here to post them.

To be honest, I don't mind if this is a blocker, freeze exception or just nothing as long as it gets fixed. Which is my goal for today.

Comment 4 Vratislav Podzimek 2015-04-10 08:10:03 UTC

(In reply to Vratislav Podzimek from comment #3)
> Well, in the case the installer is able to create and install to it, but the
* in this case...

Comment 5 Vratislav Podzimek 2015-04-10 14:54:17 UTC

Two patches sent two anaconda-patches.

Comment 6 Adam Williamson 2015-04-10 18:01:52 UTC

if it gets fixed, we don't care either =)

now Beta slipped, though, we do have a choice whether to pull it into Beta or wait for post-Beta. WDYT?

Comment 7 Vratislav Podzimek 2015-04-13 04:49:55 UTC

Well, I now have the patches ready, tested and reviewed. And they are not really intrusive so we can quite easily get them to beta.

Comment 8 Adam Williamson 2015-04-13 23:48:26 UTC

Agh, sorry, busy morning - didn't see this in time to propose for an FE. RC2 is spinning without the change. Sorry!

Comment 9 Petr Schindler 2015-04-20 16:52:11 UTC

Discussed at today's blocker review meeting [1].

This bug was rejected as Final Blocker but accepted as Freeze Exception - as described there's nothing here that really violates the criteria, the installed system seems to be operable, though not what would be reasonably expected, so accepted as a freeze exception issue.

[1] http://meetbot.fedoraproject.org/fedora-blocker-review/2015-04-20/

Comment 10 Fedora Update System 2015-04-24 02:15:34 UTC

anaconda-22.20.10-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/anaconda-22.20.10-1.fc22

Comment 11 Fedora Update System 2015-04-26 12:46:58 UTC

Package libblockdev-0.11-1.fc22, python-blivet-1.0.8-1.fc22, anaconda-22.20.10-1.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing libblockdev-0.11-1.fc22 python-blivet-1.0.8-1.fc22 anaconda-22.20.10-1.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-6866/libblockdev-0.11-1.fc22,python-blivet-1.0.8-1.fc22,anaconda-22.20.10-1.fc22
then log in and leave karma (feedback).

Comment 12 Fedora Update System 2015-04-29 12:57:21 UTC

libblockdev-0.11-1.fc22, python-blivet-1.0.8-1.fc22, anaconda-22.20.10-1.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.