Bug 1210316

Summary:	salt-minion init script kills every process
Product:	[Fedora] Fedora EPEL	Reporter:	Konrad Mosoń <mosonkonrad>
Component:	salt	Assignee:	Erik Johnson <erik>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	el6	CC:	andrewniemants, erik, herlo1, msamia, slawek.cichon
Target Milestone:	---
Target Release:	---
Hardware:	noarch
OS:	Linux
Whiteboard:
Fixed In Version:	salt-2014.7.5-1.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-04-23 19:02:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Konrad Mosoń 2015-04-09 12:58:30 UTC

Description of problem:
`/etc/init.d/salt-minion stop ` kills every salt-minion by process instead of by pid
This kills every salt-minion processes when we're using OpenVZ. On every possible container.


Version-Release number of selected component (if applicable):
<=salt-2014.7.1-1.el6.noarch.rpm
(possible every other distro with SystemV)


How reproducible:
Always.


Steps to Reproduce:
1. Install OpenVZ/any container software where processes inside container are visible on hypervisor host.
2. Install salt-minion, run it.
3. service salt-minion restart

Actual results:
salt-minion on all container are killed too.

Expected results:
salt-minion should stop/restart only process that it was started by script in init.d, and never touch processes inside containers.

Comment 1 Erik Johnson 2015-04-10 02:19:19 UTC

Konrad,

Can you backup your salt-minion init script and replace it with this: http://fpaste.org/209232/raw/

Comment 2 Erik Johnson 2015-04-10 02:25:08 UTC

If that works I will update the 2014.7.4 packages I built a couple days ago to include this fix.

Comment 3 Sławomir Cichoń 2015-04-10 11:01:14 UTC

Hi, Erik i've tested this fix and it works fine, only on hypervisor host, salt-minion process has been stopped/restarted . THX

Comment 4 Fedora Update System 2015-04-13 20:57:12 UTC

salt-2014.7.4-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/salt-2014.7.4-3.el6

Comment 5 Fedora Update System 2015-04-13 21:10:49 UTC

salt-2014.7.4-4.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/salt-2014.7.4-4.el6

Comment 6 Fedora Update System 2015-04-17 19:51:41 UTC

salt-2014.7.5-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/salt-2014.7.5-1.el6

Comment 7 Fedora Update System 2015-04-20 18:38:53 UTC

Package salt-2014.7.5-1.el6:
* should fix your issue,
* was pushed to the Fedora EPEL 6 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing salt-2014.7.5-1.el6'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2015-5893/salt-2014.7.5-1.el6
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2015-04-23 19:02:00 UTC

salt-2014.7.5-1.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.