Bug 1210502
Summary: | Implementation bug in qemuMigrationWaitForCompletion that introduces an unnecessary sleep of 50 ms when a migration completes | ||
---|---|---|---|
Product: | [Community] Virtualization Tools | Reporter: | Xing Lin <linxingnku> |
Component: | libvirt | Assignee: | Michal Privoznik <mprivozn> |
Status: | CLOSED NEXTRELEASE | QA Contact: | |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | unspecified | CC: | mprivozn, rbalakri |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-04-13 08:52:42 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Xing Lin
2015-04-09 22:20:26 UTC
I've just pushed the patch upstream: commit 522e81cbb501e9772fbafba975ac886c1b4a283d Author: Xing Lin <xinglin.edu> AuthorDate: Thu Apr 9 16:02:02 2015 -0600 Commit: Michal Privoznik <mprivozn> CommitDate: Mon Apr 13 09:52:28 2015 +0200 qemu_migration.c: sleep first before checking for migration status. The problem with the previous implementation is, even when qemuMigrationUpdateJobStatus() detects a migration job has completed, it will do a sleep for 50 ms (which is unnecessary and only adds up to the VM pause time). Signed-off-by: Xing Lin <xinglin.edu> Signed-off-by: Michal Privoznik <mprivozn> v1.2.14-108-g522e81c |