Bug 1210627

Summary: glusterd ping-timeout value available in glusterd statedump is incorrect
Product: [Community] GlusterFS Reporter: SATHEESARAN <sasundar>
Component: glusterdAssignee: Atin Mukherjee <amukherj>
Status: CLOSED CURRENTRELEASE QA Contact: SATHEESARAN <sasundar>
Severity: medium Docs Contact:
Priority: unspecified    
Version: mainlineCC: amukherj, bugs, gluster-bugs
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: glusterd
Fixed In Version: glusterfs-3.7.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-05-14 17:29:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description SATHEESARAN 2015-04-10 08:46:44 UTC
Description of problem:
-----------------------
glusterd statedump has a incorrect value for ping-timeout

Version-Release number of selected component (if applicable):
--------------------------------------------------------------
glusterfs-3.7 nightly builds ( glusterfs-3.7dev-0.952.gita7f1d08.el6.x86_64
 )

How reproducible:
-----------------
Always

Steps to Reproduce:
--------------------
1. Take a statedump of glusterd
(i.e) kill -USR1 `pidof glusterd`

2. check for the ping-timeout value available in glusterd statedump
(i.e) grep ping-timeout /var/run/gluster/glusterdump*

Actual results:
---------------
Ping timeout has a value 0 in glusterd statedump

Expected results:
-----------------
Ping timeout value available in glusterd statedump should be 30

Additional info:
-----------------
[root@ ~]# grep ping-timeout /var/run/gluster/glusterdump*
glusterd.ping-timeout=0

[root@ ~]# grep ping-timeout /etc/glusterfs/glusterd.vol 
    option ping-timeout 30

[root@ ~]# grep ping-timeout /var/log/glusterfs/etc-glusterfs-glusterd.vol.log 
  8:     option ping-timeout 30
  7:     option ping-timeout 30
  7:     option ping-timeout 30

Comment 1 Anand Avati 2015-04-10 09:53:33 UTC
REVIEW: http://review.gluster.org/10191 (glusterd: Store ping-timeout in glusterd conf in memory) posted (#1) for review on master by Atin Mukherjee (amukherj)

Comment 2 Atin Mukherjee 2015-04-13 04:48:14 UTC
Changing the version from 3.7 to mainline as the behaviour is same in current upstream repo as well.

Comment 3 Anand Avati 2015-04-14 05:21:53 UTC
COMMIT: http://review.gluster.org/10191 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit c528589a585c23b4288784247310b8763612a822
Author: Atin Mukherjee <amukherj>
Date:   Fri Apr 10 15:17:05 2015 +0530

    glusterd: Store ping-timeout in glusterd conf in memory
    
    As of now glusterd_conf_t's ping-timeout was of no use and hence statedump was
    not reflecting correct ping-timeout value configured in glusterd.vol
    
    Change-Id: I76ba7b721264565751538c7fcdcb801a28317581
    BUG: 1210627
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/10191
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>

Comment 4 Niels de Vos 2015-05-14 17:29:27 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Niels de Vos 2015-05-14 17:35:56 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:38:17 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 7 Niels de Vos 2015-05-14 17:46:49 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user