Bug 1210687

Summary:	BitRot :- If scrubber finds bad file then it should log as a 'ALERT' in log not 'Warning'
Product:	[Community] GlusterFS	Reporter:	Rachana Patel <racpatel>
Component:	bitrot	Assignee:	Satish Mohan <smohan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	low	Docs Contact:	bugs <bugs>
Priority:	unspecified
Version:	mainline	CC:	bugs, mzywusko, smohan
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1218033 1224230 (view as bug list)		Environment:
Last Closed:	2016-06-16 12:49:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1218033

Description Rachana Patel 2015-04-10 11:20:51 UTC

Description of problem:
=======================
Scrubber log should report 'bad' file detection as Error in log.


Version-Release number of selected component (if applicable):
=============================================================
3.7dev-0.952.gita7f1d08.el6.x86_64

How reproducible:
=================
always

Steps to Reproduce:
===================
1. create and mount volume.
2. enable bitrot
3. create file
4. modify file from backend(not from mount)
5. check scrub log

Actual Result:-
===============
[2015-04-09 09:14:41.002867] W [bit-rot-scrub.c:208:bitd_compare_ckum] 0-bit-rot: Object checksumsum mismatch: f9 [GFID: c2ca6098-ab30-4d9c-9027-df491e07c0f7]
[2015-04-09 09:14:41.002920] I [bit-rot-scrub.c:226:bitd_compare_ckum] 0-bit-rot: Marking f9 [GFID: c2ca6098-ab30-4d9c-9027-df491e07c0f7] as corrupted..

Expect Result:-
===============
Object Checksum mismatch should come as 'Error' not warning

Comment 1 Anand Avati 2015-04-14 05:21:40 UTC

REVIEW: http://review.gluster.org/10226 (bitrot: Scrubber log should report 'bad' file detection as Error in log) posted (#1) for review on master by Gaurav Kumar Garg (ggarg)

Comment 3 Anand Avati 2015-04-23 16:58:39 UTC

REVIEW: http://review.gluster.org/10226 (bitrot: Scrubber log should report 'bad' file detection as Error in log) posted (#2) for review on master by Gaurav Kumar Garg (ggarg)

Comment 4 Anand Avati 2015-04-24 07:27:58 UTC

REVIEW: http://review.gluster.org/10226 (bitrot: Scrubber log should report 'bad' file detection as ALERT in log) posted (#3) for review on master by Gaurav Kumar Garg (ggarg)

Comment 5 Anand Avati 2015-04-28 13:13:35 UTC

REVIEW: http://review.gluster.org/10226 (bitrot: Scrubber log should report 'bad' file detection as ALERT in log) posted (#4) for review on master by Gaurav Kumar Garg (ggarg)

Comment 6 Anand Avati 2015-04-29 06:37:31 UTC

REVIEW: http://review.gluster.org/10226 (bitrot: Scrubber log should report 'bad' file detection as ALERT in log) posted (#5) for review on master by Gaurav Kumar Garg (ggarg)

Comment 7 Anand Avati 2015-04-30 10:07:40 UTC

COMMIT: http://review.gluster.org/10226 committed in master by Venky Shankar (vshankar) 
------
commit cb8ce71560a496db5392d322b7cc663054a8457a
Author: Gaurav Kumar Garg <ggarg>
Date:   Tue Apr 14 00:48:24 2015 +0530

    bitrot: Scrubber log should report 'bad' file detection as ALERT in log
    
    If scrubber detect any bad object by mismatching of checksum of scrubber
    and signer then log messages shold come as a Alert instead of warning.
    
    Change-Id: I075d80700cbe6182e525a04419a80ab18419ff91
    BUG: 1210687
    Signed-off-by: Gaurav Kumar Garg <ggarg>
    Reviewed-on: http://review.gluster.org/10226
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra Bhat <raghavendra>

Comment 8 Gaurav Kumar Garg 2015-04-30 10:14:59 UTC

If scrubber detect any bad object by mismatching of checksum of scrubber
and signer then log messages shold come as a Alert instead of warning.

Comment 9 Nagaprasad Sathyanarayana 2015-10-25 14:54:38 UTC

Fix for this bug is already made in a GlusterFS release. The cloned BZ has details of the fix and the release. Hence closing this mainline BZ.

Comment 10 Nagaprasad Sathyanarayana 2015-10-25 14:57:39 UTC

Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 12 Niels de Vos 2016-06-16 12:49:31 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user