Bug 1211550

Summary: weird error report when fail to parse parameter --soft-limit of memtune
Product: Red Hat Enterprise Linux 7 Reporter: Shanzhi Yu <shyu>
Component: libvirtAssignee: Ján Tomko <jtomko>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.2CC: dyuan, fjin, jtomko, lhuang, mzhan, rbalakri
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-1.2.15-1.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-11-19 06:28:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Shanzhi Yu 2015-04-14 10:03:47 UTC 
Description of problem:

weird error report when fail to parse parameter --soft-limit of memtune

Version-Release number of selected component (if applicable):

libvirt-1.2.14-1.el7.x86_64

How reproducible:

100%

Steps to Reproduce:

1. Prepare a running guest
# virsh list
 Id    Name                           State
----------------------------------------------------
 2     r7                             running


2. set guest memory parameters

# virsh memtune r7 --hard-limit 20417224 --soft-limit 9007199254740992  --swap-hard-limit 35417224
error: Unable to parse integer parameter 'NAME'


Actual results:


Expected results:

A more readable error like

# virsh memtune r7 --hard-limit 20417224 --soft-limit 9007199254740992  --swap-hard-limit 35417224
error: Unable to parse integer parameter soft-limit

Additional info:
Comment 1 Ján Tomko 2015-04-14 12:17:53 UTC 
Fixed upstream by:
commit 8ff9f2457dd02627587457c2d7879180c8b872ef
Author:     Shanzhi Yu <shyu>
AuthorDate: 2015-04-14 18:24:40 +0800
Commit:     Ján Tomko <jtomko>
CommitDate: 2015-04-14 13:48:29 +0200

    virsh: improve the error for wrong memtune parameters
    
    When set guest memory with a invalid parameter of --soft-limit,
    it posts weird error:
    
    $ virsh memtune r7 --hard-limit 20417224 --soft-limit 9007199254740992 \
      --swap-hard-limit 35417224
    error: Unable to parse integer parameter 'NAME
    
    Change it to
    
    error: Unable to parse integer parameter soft-limit
    
    Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1211550
    Signed-off-by: Shanzhi Yu <shyu>
    Signed-off-by: Ján Tomko <jtomko>

git describe: v1.2.14-145-g8ff9f24
Comment 3 Fangge Jin 2015-07-13 10:05:43 UTC 
I can reproduce this bug on build libvirt-1.2.14-1.el7.x86_64.

Verify this bug on build libvirt-1.2.17-2.el7.x86_64.

Verify steps:
1. Prepare a running guest
# virsh list
 Id    Name                           State
----------------------------------------------------
 2     r7                             running


2. set guest memory parameters

# virsh memtune r7 --hard-limit 20417224 --soft-limit 9007199254740992  --swap-hard-limit 35417224
error: Unable to parse integer parameter soft-limit

Move to verified.
Comment 5 errata-xmlrpc 2015-11-19 06:28:26 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2202.html