Bug 1212411

Summary:	Attempts to create an instance in a readonly domain via automate should log a warning
Product:	Red Hat CloudForms Management Engine	Reporter:	Pete Savage <psavage>
Component:	Automate	Assignee:	mkanoor
Status:	CLOSED ERRATA	QA Contact:	Dave Johnson <dajohnso>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	5.4.0	CC:	jhardy, mkanoor, obarenbo, tfitzger
Target Milestone:	GA
Target Release:	5.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-06-16 12:58:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Pete Savage 2015-04-16 11:04:56 UTC

Description of problem: With the resolution of https://bugzilla.redhat.com/show_bug.cgi?id=1142317 we should now add something to report back if the domain was readonly, and not just silently fail.


Version-Release number of selected component (if applicable): 5.4.0.0.19


How reproducible: 100%


Steps to Reproduce:
1. Create a automate method script
2. In the script call $evm.instance_create with the path containing the name of a readonly (locked) domain

Actual results: The instance create will fail but no log generated


Expected results: A log message should be generated, currently the log looks like this

[----] I, [2015-04-16T06:57:21.777615 #24235:85f0c00]  INFO -- : MiqAeService#instance_create << path="/ManageIQ/System/Request/Doughnut", values_hash={}

Which looks like it passed, except it didn't :)

Additional info:

Comment 2 CFME Bot 2015-04-16 15:11:41 UTC

New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/1df41bf5ced73b30e23044f5c0484c6dfa6ac4dd

commit 1df41bf5ced73b30e23044f5c0484c6dfa6ac4dd
Author:     Madhu Kanoor <mkanoor>
AuthorDate: Thu Apr 16 09:59:03 2015 -0400
Commit:     Madhu Kanoor <mkanoor>
CommitDate: Thu Apr 16 09:59:03 2015 -0400

    Log a warning for uneditable automate instances
    
    The automate methods
    $evm.instance_delete
    $evm.instance_update
    $evm.instance_create
    
    Have been returning a false for uneditable instances and the
    caller can check the return value and log an error. Based on
    the request from this ticket we will now log a warning if the
    instance is not editable
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1212411

 vmdb/lib/miq_automation_engine/engine/miq_ae_service.rb | 1 +
 1 file changed, 1 insertion(+)

Comment 4 Pete Savage 2015-05-20 12:20:47 UTC

Verified in 5.4.0.1

Comment 6 errata-xmlrpc 2015-06-16 12:58:37 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html