Bug 1212466

Summary:	Error creating a dialog based on an orchestration template without parameters
Product:	Red Hat CloudForms Management Engine	Reporter:	Bill Wei <bilwei>
Component:	Provisioning	Assignee:	Bill Wei <bilwei>
Status:	CLOSED ERRATA	QA Contact:	Dave Johnson <dajohnso>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	5.4.0	CC:	jhardy, obarenbo, sshveta
Target Milestone:	GA
Target Release:	5.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-06-16 12:58:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Bill Wei 2015-04-16 13:22:54 UTC

Description of problem:
"Error when creating a Service Dialog from Orchestration Template: undefined method `collect' for nil:NilClass" was raised when the orchestration template does not contain a parameters section

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Prepare an orchestration template with no parameters section
2. Browse the template and select Configuration/Create Service Dialog from Orchestration Template menu
3.

Actual results:
An error is shown on screen:"Error when creating a Service Dialog from Orchestration Template: undefined method `collect'

Expected results:
A dialog should be created

Additional info:

Comment 2 CFME Bot 2015-04-16 19:25:52 UTC

New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/da6ab848a5d4bdbf9aa641928d12d9c7594e6f32

commit da6ab848a5d4bdbf9aa641928d12d9c7594e6f32
Author:     Bill Wei <bilwei>
AuthorDate: Wed Apr 15 17:28:50 2015 -0400
Commit:     Bill Wei <bilwei>
CommitDate: Thu Apr 16 10:57:48 2015 -0400

    Avoid NilClass error when no parameters in a template
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1212466

 vmdb/app/models/orchestration_template_cfn.rb      |  2 +-
 vmdb/app/models/orchestration_template_hot.rb      |  2 +-
 .../orchestration_template_dialog_service_spec.rb  | 22 ++++++++++++++++++----
 3 files changed, 20 insertions(+), 6 deletions(-)

Comment 4 Shveta 2015-04-29 21:40:21 UTC

Fixed in 5.4.0.0.22.20150420163946_26004d1

Comment 6 errata-xmlrpc 2015-06-16 12:58:44 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html