Bug 1212625

Summary:	[RDO-Manager][Heat] : get_file for existing resources during update looks in new environment
Product:	Red Hat OpenStack	Reporter:	Omri Hochman <ohochman>
Component:	openstack-heat	Assignee:	Zane Bitter <zbitter>
Status:	CLOSED ERRATA	QA Contact:	Amit Ugol <augol>
Severity:	high	Docs Contact:
Priority:	medium
Version:	7.0 (Kilo)	CC:	ddomingo, jprovazn, jschluet, rlandy, sbaker, sclewis, shardy, yeylon
Target Milestone:	ga
Target Release:	7.0 (Kilo)
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	openstack-heat-2015.1.0-1.el7ost	Doc Type:	Bug Fix
Doc Text:	When the 'files' section of an environment were changed in a stack update, the Orchestration service combined new files with the old stack definition to calculate the previous state. The objective of this was to compare the previous state against the new files and new template. As a result, the Orchestration service did not notice changes in the included files, so any updates predicated solely on changes to the files would not occur. In addition, if a previously-referenced file was removed from the environment in a stack update, the stack update would fail (though later updates with the same data could succeed). With this release, the Orchestration service now combines the old stack with the old files to compare agains the new template and new files. Updates now work as expected when editing included files in the environment.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-08-05 13:22:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Omri Hochman 2015-04-16 20:10:25 UTC

[RDO-Manager][Heat] : get_file doesn't notice changes during update cause the first attempt of running 'openstack stack scale -r Compute-1 -n 2' to fail. 


Environment :
--------------
[root@localhost ~]# rpm -qa | grep heat
openstack-heat-engine-2015.1-dev829.el7.centos.noarch
openstack-heat-templates-4643876-0.99.20150327.1822git.el7.centos.noarch
heat-cfntools-1.2.8-2.el7.centos.noarch
openstack-heat-common-2015.1-dev829.el7.centos.noarch
openstack-heat-api-2015.1-dev829.el7.centos.noarch
python-heatclient-0.3.0-post14.el7.centos.noarch
openstack-tripleo-heat-templates-0.8.3-post32.el7.centos.noarch
openstack-heat-api-cloudwatch-2015.1-dev829.el7.centos.noarch
openstack-heat-api-cfn-2015.1-dev829.el7.centos.noarch



Description : 
-------------
Due to a problem in heat "get_file doesn't notice changes during update" 
(see https://bugs.launchpad.net/heat/+bug/1445170)  - when attempting to scale out nova-compute node after the overcloud is deployed - the command  "openstack stack scale -r Compute-1 -n 2 " failed on the first attempt, but it pass on the second attempt.  

Steps to reproduce: 
--------------------

(1) Follow the steps to install undercloud and overcloud  : https://repos.fedorapeople.org/repos/openstack-m/instack-undercloud/internal-html/ 

(2) Follow the steps to attempt to scale the number of compute node  (In case the code already merged midstream just skip to step #3). 

git clone https://github.com/jprovaznik/tripleo-common
git clone https://github.com/jprovaznik/python-rdomanager-oscplugin/tree/updates
 virtualenv ~/venv
 source ~/venv/bin/activate
 cd tripleo-common
 python setup.py install
 cd python-rdomanager-oscplugin
 python setup.py install
 run "openstack stack scale"

(3) openstack stack scale -r Compute-1 -n 2 


Results: 
---------
The command 'openstack stack scale -r Compute-1 -n 2  ' will fail when attempting to run it for the first time .  

Note: 
-----
The command will succeed when running it for the second time.

Comment 4 Zane Bitter 2015-06-17 22:26:18 UTC

The fix made it in to the upstream 2015.1 (Kilo) release.

Comment 5 Jon Schlueter 2015-06-18 14:14:21 UTC

update fixed in version for full package name

Comment 8 Amit Ugol 2015-07-13 13:27:34 UTC

No way to try and reproduce now with the exact command as the commands are outdated and will never be used.
Running openstack overcloud update stack seems to work better (note that there were Tuskar bugs here, but those are out of scope).

Comment 10 errata-xmlrpc 2015-08-05 13:22:47 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2015:1548