Bug 1213014

Summary: Main login screen spins forever with invalid Kerberos SSO ticket
Product: Red Hat CloudForms Management Engine Reporter: abellott
Component: UI - OPSAssignee: abellott
Status: CLOSED ERRATA QA Contact: Milan Falešník <mfalesni>
Severity: high Docs Contact:
Priority: high    
Version: 5.4.0CC: cpelland, hkataria, jhardy, mfalesni, mpovolny, obarenbo
Target Milestone: GA   
Target Release: 5.4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-06-16 12:58:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description abellott 2015-04-17 23:47:32 UTC
Description of problem:

Kerberos SSO UI spinner with invalid/non-existant

Version-Release number of selected component (if applicable):

5.4.25 

How reproducible:

Steps to Reproduce:
1. install appliance
2. enable IPA/external auth
3. enable external auth in UI and enable SSO

Actual results:

Hit appliance UI main login screen, spinner spins forever

Expected results:

Error message:  Error: Invalid Single Sign-On credentials

Additional info:

Upon invalid Kerberos SSO, the javascript for the error comes to us from outside CloudForms's /, specifically /var/www/html/proxy_pages/invalid_sso_credentials.js

The javascript there is no longer valid with 5.4:

Element.update("flash_div", "Error: Invalid Single Sign-On credentials")
$("flash_div").show()
miqSparkle(false)
miqEnableLoginFields(true);

Primarily the flash code, I've attempted the following:

$('#flash_msg_div').text("Error: Invalid Single Sign-On credentials")
$('#flash_msg_div').show()
miqSparkle(false)
miqEnableLoginFields(true);

While it works, it's not the right way/look and feel as the current flash error messages as the current UI.

Comment 2 abellott 2015-04-18 00:43:39 UTC
Hopefully a little better solution @ https://github.com/ManageIQ/manageiq/pull/2671

Comment 3 CFME Bot 2015-04-24 21:36:00 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/d1ef23c8a9d21789992fca13ac10a2797888f88f

commit d1ef23c8a9d21789992fca13ac10a2797888f88f
Author:     Alberto Bellotti <abellott>
AuthorDate: Fri Apr 17 20:30:13 2015 -0400
Commit:     Alberto Bellotti <abellott>
CommitDate: Fri Apr 17 20:30:13 2015 -0400

    Kerberos SSO with Invalid credentials spins login screen forever.
    
    Upon invalid kerberos SSO, the error javascript comes to us from outside
    the application /, namely proxy_pages/invalid_sso_credentials.js
    
    The javascript in that is no longer compatible with the later UI bits
    for flash messages.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1213014

 .../html/proxy_pages/invalid_sso_credentials.js    | 23 ++++++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)

Comment 4 CFME Bot 2015-04-24 21:36:04 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/77248aafd7cc2ae3bdd057323366b09d81a2ab02

commit 77248aafd7cc2ae3bdd057323366b09d81a2ab02
Author:     Alberto Bellotti <abellott>
AuthorDate: Mon Apr 20 16:25:44 2015 -0400
Commit:     Alberto Bellotti <abellott>
CommitDate: Tue Apr 21 20:04:19 2015 -0400

    PR Review changes
    
    - making the invalid_sso_credentials.js coming from outside the proxy more generic.
    - leveraging the dashboard login haml to contain the invalid_sso_credentials_flash logic.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1213014

 .../html/proxy_pages/invalid_sso_credentials.js    | 25 ++++------------------
 vmdb/app/views/dashboard/login.html.haml           |  7 ++++++
 2 files changed, 11 insertions(+), 21 deletions(-)

Comment 5 Oleg Barenboim 2015-04-26 22:04:28 UTC
Is this ready to move to POST or are there more fixes pending?

Comment 6 Milan Falešník 2015-04-30 13:28:13 UTC
Verified in 5.2.0.0.24, now there is the flash message and no forever-blocking spinner.

Comment 9 errata-xmlrpc 2015-06-16 12:58:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html