Bug 1213202

Summary: [virt-manager]wrong error message always show after add the second one failed for a single supported device
Product: Red Hat Enterprise Linux 7 Reporter: vivian zhang <vivianzhang>
Component: virt-managerAssignee: Giuseppe Scrivano <gscrivan>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.1CC: dyuan, mzhan, rbalakri, tzheng
Target Milestone: rcKeywords: Upstream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: virt-manager-1.2.0-1-el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-11-19 05:25:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
virt-manager debug log none

Description vivian zhang 2015-04-20 02:51:02 UTC
Created attachment 1016198 [details]
virt-manager debug log

Description:
For watchdog, tpm and panic devices, libvirt only support add single one for them. After trying to add the second one for them, the wrong error message will always show even though you do other right actions with virt-manager.

Version-Release number of selected component (if applicable):
virt-manager-1.1.0-12.el7.noarch
qemu-kvm-rhev-2.2.0-8.el7.x86_64
libvirt-1.2.14-1.el7.x86_64



How reproducible:
100%

Steps:

1. launch virt-manager
2. prepare a health guest without tpm watchdog or panic devices
3. Open the guest and turn to "Hardware Details" page, and then click "Add Hardware"->choose "watchdog"-> add the first one watchdog device -> click 'Finish'.It will success to be added to guest.
4. try to add the second one, virt-manager report error
"Error adding device: internal error: only a single watchdog device is supported"
5. try to add other devices with virt-manager, such as video device, the above error "Error adding device: internal error: only a single watchdog device is supported" show again, you can not do any other right actions for this guest with virt-manager.
6. the same result also hit on tpm and panic devices




Actual result:
After step 4, the error message always show again and again for other actions in virt-manager

Expect result:
After step 4,the wrong message should not show up even though you do other right actions for guest

Additional info:
virt-manager debug info will be attached

Comment 3 Giuseppe Scrivano 2015-04-20 12:42:04 UTC
fixed upstream by:

commit 1c63c2b0d9029b794793ebaa456bf2b139b5d77c
Author: Cole Robinson <crobinso>
Date:   Thu Apr 9 13:01:38 2015 -0400

    libvirtobject: Invalidate cache if redefine fails

Comment 5 Giuseppe Scrivano 2015-05-06 08:36:50 UTC
*** Bug 1183604 has been marked as a duplicate of this bug. ***

Comment 6 fwu 2015-05-18 04:59:46 UTC
I can reproduce this issue with package:
virt-manager-1.1.0-12.el7.noarch

Steps are same as those in description.

Result:
The error message come out as described.
The problem also exists for TPM and panic notifier.

Then try to verify with new build:
virt-manager-1.2.0-3.el7.noarch

Steps:

1. launch virt-manager
2. prepare a health guest without tpm watchdog or panic devices
3. Open the guest and turn to "Hardware Details" page, and then click "Add Hardware">choose "watchdog"> add the first watchdog device -> click 'Finish'. The watchdog device will be added to the guest successfully.
4. Try to add the second one, virt-manager report error
"Error adding device: internal error: only a single watchdog device is supported".
5. Try to add other devices with virt-manager, such as video device, sound device etc.

Result:
After first watchdog device/TPM/panic notifier was added, error message will occur when adding the same device second time.
Other devices such as video device can be added successfully.

According to the result above in the latest version of virt-manager, move this bug from ON_QA to VERIFIED.

Comment 9 errata-xmlrpc 2015-11-19 05:25:31 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2206.html