Bug 1213247

Summary:	virt tools should print the same format of version string
Product:	[Fedora] Fedora	Reporter:	Lingfei Kong <lkong>
Component:	libguestfs	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED UPSTREAM	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	low
Version:	22	CC:	huzhan, leiwang, mbooth, ptoscano, rjones, virt-maint, wshi
Target Milestone:	---	Keywords:	Improvement
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-04-20 07:55:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lingfei Kong 2015-04-20 07:08:13 UTC

Description of problem:
When i tesing virt tools i found most of the virt tools's version string format are:
virt-xx 1.29.33fedora=22,release=1.fc22,libvirt

But some of the virt tools's version string are not. Such as:
virt-builder, virt-customize, virt-index-validate, virt-resize, virt-sysprep, virt-sparsify are in format 'virt-xx 1.29.33'

virt-tar, virt-win-reg, virt-list-filesystems, virt-list-partitions are in format '1.29.33fedora=22,release=1.fc22,libvirt'

Print a consistency version format for all virt tools should be always good.

This is just a improvement, i would like to put this bug as a very low priority. If it is not necessary to change, feel free to close it as NOTABUG.


Version-Release number of selected component (if applicable):
libguestfs-tools-c-1.29.33-1.fc22.x86_64


How reproducible:
100%


Steps to Reproduce:
# virt-xx --version


Actual results:


Expected results:


Additional info:

Comment 1 Richard W.M. Jones 2015-04-20 07:55:32 UTC

I didn't fix virt-tar, virt-list-filesystems and virt-list-partitions
since those are legacy tools that we don't care about and will probably
remove soon.

The other tools mentioned above, and virt-v2v and virt-p2v, are fixed by:

https://github.com/libguestfs/libguestfs/commit/478a552ab431762dd2a724ade0c3fd84a21b7cab
https://github.com/libguestfs/libguestfs/commit/3b3f06d2247562cbdb7ed70868ffb3f9c18e8a32
https://github.com/libguestfs/libguestfs/commit/86a91d6c65d6fe5da45bd827287cd9800ece721e