Bug 1213423

Summary: segfault on daemon exit
Product: [Fedora] Fedora Reporter: Yanko Kaneti <yaneti>
Component: opensshAssignee: Jakub Jelen <jjelen>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: jjelen, lnie, mattias.ellert, mgrepl, plautrba, tmraz
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openssh-6.8p1-5.fc22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-04-23 16:11:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Yanko Kaneti 2015-04-20 14:13:43 UTC
Description of problem:
$ systemctl stop sshd.service 


           PID: 1083 (sshd)
           UID: 0 (root)
           GID: 0 (root)
        Signal: 11 (SEGV)
     Timestamp: Mon 2015-04-20 17:07:09 EEST (5min ago)
  Command Line: /usr/sbin/sshd -D
    Executable: /usr/sbin/sshd
 Control Group: /system.slice/sshd.service
          Unit: sshd.service
         Slice: system.slice
       Boot ID: d844bfa107204255a0ce859060a41ec7
    Machine ID: 4b741960432e833443a6bc004563501d
      Hostname: d2
      Coredump: /var/lib/systemd/coredump/core.sshd.0.d844bfa107204255a0ce859060a41ec7.1083.1429538829000000.xz
       Message: Process 1083 (sshd) of user 0 dumped core.
                
                Stack trace of thread 1083:
                #0  0x000055f8a0c60f5d ssh_packet_connection_is_on_socket (sshd)
                #1  0x000055f8a0c52e41 set_remote_ipaddr (sshd)
                #2  0x000055f8a0c52ea9 get_remote_ipaddr (sshd)
                #3  0x000055f8a0c1d355 audit_destroy_sensitive_data (sshd)
                #4  0x000055f8a0c1a83d destroy_sensitive_data (sshd)
                #5  0x000055f8a0c19470 main (sshd)
                #6  0x00007fc5bbe39840 __libc_start_main (libc.so.6)
                #7  0x000055f8a0c19cf9 _start (sshd)




Core was generated by `/usr/sbin/sshd -D'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  ssh_packet_connection_is_on_socket (ssh=0x0) at packet.c:371
371		struct session_state *state = ssh->state;
Missing separate debuginfos, use: dnf debuginfo-install fipscheck-lib-1.4.1-8.fc23.x86_64 glibc-2.21.90-7.fc23.x86_64 pam-1.1.8-18.fc23.x86_64
(gdb) p ssh
$1 = (struct ssh *) 0x0
(gdb) quit


Version-Release number of selected component (if applicable):
openssh-server-6.8p1-4.fc23.x86_64

Comment 1 Jakub Jelen 2015-04-20 15:38:02 UTC
Thank you for reporting. There was some another API change I didn't notice in last 
It should be fixed now by correct handling remoteip during cleanup phase. Can you please retest it with this scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=9519352

I will push it into rawhide and F22 then.

Comment 2 Yanko Kaneti 2015-04-20 15:47:28 UTC
The scratch build fixes it for me, and otherwise appears to work, thanks.

Comment 3 Fedora Update System 2015-04-21 07:01:04 UTC
openssh-6.8p1-5.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/openssh-6.8p1-5.fc22

Comment 4 Fedora Update System 2015-04-22 22:48:37 UTC
Package openssh-6.8p1-5.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing openssh-6.8p1-5.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-6630/openssh-6.8p1-5.fc22
then log in and leave karma (feedback).

Comment 5 lnie 2015-04-23 07:57:54 UTC
openssh-6.8p1-5.fc22 works

Comment 6 Fedora Update System 2015-04-23 16:11:20 UTC
openssh-6.8p1-5.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.