Bug 1213484

Summary: No AArch64 support in Singular
Product: [Fedora] Fedora Reporter: Marcin Juszkiewicz <mjuszkie>
Component: SingularAssignee: Paulo Andrade <paulo.cesar.pereira.de.andrade>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: paulo.cesar.pereira.de.andrade, rdieter
Target Milestone: ---   
Target Release: ---   
Hardware: aarch64   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-05-01 04:08:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 922257    
Attachments:
Description Flags
patch which got it built for me none

Description Marcin Juszkiewicz 2015-04-20 16:51:23 UTC 
Description of problem:

Singular does not recognize AArch64 architecture and due to this do not build everything (dbmsr.so etc).

Version-Release number of selected component (if applicable):

3.1.6-11

How reproducible:

always

Steps to Reproduce:
1. do a build for aarch64 (arm-koji)
2.
3.

Actual results:

First:

creating cache ./config.cache
checking uname for singular... unknown
configure: warning: Unknown architecture: Check singuname.sh

Then:

+ pushd /builddir/build/BUILDROOT/Singular-3.1.6-7.fc21.aarch64/usr/lib64
+ mkdir -p Singular
+ mv dbmsr.so 'p_Procs*.so' Singular
mv: cannot stat 'dbmsr.so': No such file or directory
mv: cannot stat 'p_Procs*.so': No such file or directory
RPM build errors:

Expected results:

package builds

Additional info:
Comment 1 Marcin Juszkiewicz 2015-04-20 16:53:11 UTC 
Created attachment 1016452 [details]
patch which got it built for me

With this small patch it built for me.

But when I look at amount of code for ARM and s390 then I do not know is it all what is needed.
Comment 2 Paulo Andrade 2015-04-26 16:50:35 UTC 
I updated the existing -arches.patch, but did not test it so far
on aarch64. See
http://pkgs.fedoraproject.org/cgit/Singular.git/commit/?id=90662c5251ab9e93422685eb14cf20a8d8d4ea84

I think what is more important is to just not guess

...
#elif defined(SI_CPU_AARCH64)
  // FIXME: need to run some tests
  #define HAVE_MULT_MOD
  #define HAVE_GENERIC_ADD
  #ifdef HAVE_MULT_MOD
  #define HAVE_DIV_MOD
  #endif
...

but it should be upstream to make benchmark tests...
Comment 3 Marcin Juszkiewicz 2015-04-27 05:03:40 UTC 
Package builds:

Wrote: /builddir/build/RPMS/factory-devel-3.1.6-12.fc23.aarch64.rpm
Wrote: /builddir/build/RPMS/factory-gftables-3.1.6-12.fc23.noarch.rpm
Wrote: /builddir/build/RPMS/libfac-devel-3.1.6-12.fc23.aarch64.rpm
Wrote: /builddir/build/RPMS/Singular-examples-3.1.6-12.fc23.aarch64.rpm
Wrote: /builddir/build/RPMS/Singular-doc-3.1.6-12.fc23.aarch64.rpm
Wrote: /builddir/build/RPMS/Singular-surfex-3.1.6-12.fc23.aarch64.rpm
Wrote: /builddir/build/RPMS/Singular-emacs-3.1.6-12.fc23.aarch64.rpm
Wrote: /builddir/build/RPMS/Singular-debuginfo-3.1.6-12.fc23.aarch64.rpm
Comment 4 Paulo Andrade 2015-05-01 04:08:13 UTC 
If there any remaining issues please report again.