Bug 1213595

Summary:	Review Request: mediawiki123-intersection - Create a list of pages that are listed in a set of categories
Product:	[Fedora] Fedora	Reporter:	Patrick Uiterwijk <puiterwijk>
Component:	Package Review	Assignee:	Kevin Fenzi <kevin>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	kevin, package-review
Target Milestone:	---	Flags:	kevin: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	mediawiki123-intersection-1.7.0-1.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-05-29 21:48:16 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Patrick Uiterwijk 2015-04-20 21:03:18 UTC

Spec URL: http://puiterwijk.fedorapeople.org//mediawiki123-intersection.spec
SRPM URL: http://puiterwijk.fedorapeople.org//mediawiki123-intersection-1.7.0-1.fc21.src.rpm

Description:
Outputs a bulleted list of most recent items
residing in a category, or an intersection
of several categories.
DynamicPageList is another name for this extension.

Comment 1 Patrick Uiterwijk 2015-04-20 21:04:52 UTC

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9522610

I'm only interrested in EPEL7.

Comment 2 Kevin Fenzi 2015-04-20 21:08:25 UTC

Will review this. Look for full review in a bit...

Comment 3 Kevin Fenzi 2015-04-20 21:16:42 UTC

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (GPLv2+)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
9df8930cab9db47dbc6173c45afb5945  intersection-REL1_23-1a507c8.tar.gz

OK - BuildRequires correct
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have sane scriptlets. 
OK - Should have dist tag
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin

Issues: 

1. Might ask upstream to include a copy of the GPLv2 (nonblocker)

2. Your comment in changelog says "1.23", but this is 1.7.0. (nonblocker)
(please fix on import)

3. rpmlint says: 

mediawiki123-intersection.noarch: W: spelling-error %description -l en_US bulleted -> billeted, bullet ed, bullet-ed
mediawiki123-intersection.noarch: W: no-documentation
mediawiki123-intersection.src: W: spelling-error %description -l en_US bulleted -> billeted, bullet ed, bullet-ed
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

All can be ignored. 

I don't see any blockers here, so this package is APPROVED.

Comment 4 Fedora Update System 2015-04-20 22:17:08 UTC

mediawiki123-intersection-1.7.0-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/mediawiki123-intersection-1.7.0-1.el7

Comment 5 Fedora Update System 2015-04-22 05:09:34 UTC

mediawiki123-intersection-1.7.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository.

Comment 6 Fedora Update System 2015-05-29 21:48:16 UTC

mediawiki123-intersection-1.7.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository.