Bug 1213773

Summary:	upcall: polling is done for a invalid file
Product:	[Community] GlusterFS	Reporter:	Jiffin <jthottan>
Component:	upcall	Assignee:	Soumya Koduri <skoduri>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	mainline	CC:	jthottan, skoduri
Target Milestone:	---	Keywords:	Reopened, Triaged
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1218566 (view as bug list)		Environment:
Last Closed:	2016-06-16 12:53:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1218566

Description Jiffin 2015-04-21 09:20:33 UTC

Description of problem:

glfs_h_poll_upcall() is used to poll upcall events which is stored in upcall list. If list contains invalid entries it should be removed , so further polling of the same can be avoided.


Version-Release number of selected component (if applicable):

mainline

How reproducible:
always


Actual results:
polling is done for invalid entries

Expected results:
polling should not done for invalid entries

Additional info:

This issue was faced while running perf test on pnfs.
snippet from gfapi logs :
[2015-04-21 07:24:39.734836] W [glfs-handleops.c:1163:pub_glfs_h_create_from_handle] 0-meta-autoload: inode refresh of 204a66bc-f262-4a8e-b5e3-9be4fd5bf07c failed: Stale file handle
[2015-04-21 07:24:39.768259] W [glfs-handleops.c:1163:pub_glfs_h_create_from_handle] 0-meta-autoload: inode refresh of 204a66bc-f262-4a8e-b5e3-9be4fd5bf07c failed: Stale file handle
[2015-04-21 07:24:39.803004] W [glfs-handleops.c:1163:pub_glfs_h_create_from_handle] 0-meta-autoload: inode refresh of 204a66bc-f262-4a8e-b5e3-9be4fd5bf07c failed: Stale file handle
[2015-04-21 07:24:39.844828] W [glfs-handleops.c:1163:pub_glfs_h_create_from_handle] 0-meta-autoload: inode refresh of 204a66bc-f262-4a8e-b5e3-9be4fd5bf07c failed: Stale file handle

snippet from nfs-ganesha.log
21/04/2015 05:17:19 : epoch 5535049d : heka-client-13.gdev.lab.eng.bos.redhat.com : ganesha.nfsd-19940[fsal_up_0x7f811] GLUSTERFSAL_UP_Thread :FSAL_UP :CRIT :OPENHANDLE_INODE_UPDATE failed for 0x7f811ae80780. rc -1 errno 12 (Cannot allocate memory) reason 2
21/04/2015 05:17:20 : epoch 5535049d : heka-client-13.gdev.lab.eng.bos.redhat.com : ganesha.nfsd-19940[fsal_up_0x7f811] GLUSTERFSAL_UP_Thread :FSAL_UP :CRIT :OPENHANDLE_INODE_UPDATE failed for 0x7f811ae80780. rc -1 errno 12 (Cannot allocate memory) reason 2
21/04/2015 05:17:20 : epoch 5535049d : heka-client-13.gdev.lab.eng.bos.redhat.com : ganesha.nfsd-19940[fsal_up_0x7f811] GLUSTERFSAL_UP_Thread :FSAL_UP :CRIT :OPENHANDLE_INODE_UPDATE failed for 0x7f811ae80780. rc -1 errno 12 (Cannot allocate memory) reason 2

Comment 1 Anand Avati 2015-04-22 17:10:13 UTC

REVIEW: http://review.gluster.org/10341 (gfapi: Skip and delete the upcall entry if not found) posted (#1) for review on master by soumya k (skoduri)

Comment 2 Anand Avati 2015-04-27 08:54:13 UTC

REVIEW: http://review.gluster.org/10341 (gfapi: Skip and delete the upcall entry if not found) posted (#2) for review on master by soumya k (skoduri)

Comment 3 Anand Avati 2015-05-04 12:28:30 UTC

REVIEW: http://review.gluster.org/10341 (gfapi: Skip and delete the upcall entry if not found) posted (#4) for review on master by soumya k (skoduri)

Comment 4 Nagaprasad Sathyanarayana 2015-10-25 14:55:13 UTC

Fix for this bug is already made in a GlusterFS release. The cloned BZ has details of the fix and the release. Hence closing this mainline BZ.

Comment 5 Nagaprasad Sathyanarayana 2015-10-25 15:01:27 UTC

Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 6 Niels de Vos 2016-06-16 12:53:42 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user