Bug 1213848
Summary: | [RFE] implement automatically yes mode in run() | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Igor Gnatenko <ignatenko> |
Component: | dnf-plugins-extras | Assignee: | rpm-software-management |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | e, extras-qa, ignatenko, jkadlcik, jmracek, jrohel, jzeleny, mluscon, msuchy, packaging-team-maint, rjones, rpm-software-management, vmukhame, xjakub |
Target Milestone: | --- | Keywords: | EasyFix, Triaged |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | 1211344 | Environment: | |
Last Closed: | 2017-08-31 10:34:11 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1211344 |
Description
Igor Gnatenko
2015-04-21 12:32:07 UTC
rpmconf does not have any safe option which can be executed when -y is passed. What I recommend is to call rpmconf.rpmconf(..., test=True) when -y is passed to DNF. This will print files which need to be merged and returns non zero result. Or it return 0 if there are no files to merge Rpmconf plugin should IMO jest test the existence of those file when -y is used and do not try to actually merge anything. Note: test=True just landed in master and will be available in rawhide in day or two. >Description of problem: > >If you accidentally install the rpmconf plugin, then you >see apt-like interactive file updates: I done some tests today: I could't reproduce the problem. So I looked to the code of rpmconf plugin. Probably this problem was fixed 10 months ago: https://github.com/rpm-software-management/dnf-plugins-extras/commit/f9f3b94bb012624520fb25e91cb1930c579f7ef3 This patch sets non-interactive mode for -y. It seems that plugin only reads its configuration in this mode, nothing more. So from my point of view it is about documentation now. We must explain meaning of -y option to user (it is about switching to non-interactive mode and answer yes to simple yes/no questions?). Because "-y" switch: "answer yes for all questions" is not true now. Or we can add new option for activating non-interactive mode. And -y can be used as proposed in documentation. Always assume yes. Eg. help for aptitude (pkg manager application in Debian) says: "-y Assume that the answer to simple yes/no questions is 'yes'." So only for simple questions. So again main problem of rpmconf plugin was fixed 10 months ago. What we can do now? - change documentation of -y option - improve rpmconf pugin non-interactive mode - to print which file need to be merged (silently ignored now) as supposed by Miroslav Suchý - introduce a new option for non-interactive mode (probably no, another incompatibility) We really need a "just do it" option, so we can run dnf under virt-customize. There is *no interactivity possible* in this scenario, so anything which interacts with the user is broken. *** Bug 1211344 has been marked as a duplicate of this bug. *** It looks like that the issue was fixed in dnf-plugin-rpmconf-2.0.0-1 available for Fedora 26+. Please if you will find that current implementation is incorrect, please don't hesitate to reopen the bug report. |