Bug 1214120

Summary: [regression] Gnome-shell 3.16.1 update broke X session on hybrid laptop
Product: [Fedora] Fedora Reporter: Luya Tshimbalanga <luya>
Component: gnome-shellAssignee: Owen Taylor <otaylor>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 22CC: aneil2, awilliam, drago01, fmuellner, luya, otaylor, robatino
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: mutter-3.16.1.1-3.fc22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-05-04 15:26:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1043130    
Attachments:
Description Flags
dmesg report
none
Relevant journal report with backtrace
none
journal -r | grep gnome
none
Xorg log none

Description Luya Tshimbalanga 2015-04-22 03:54:06 UTC
Created attachment 1017215 [details]
dmesg report

Description of problem:
Update to 3.16.1 led to crashed X session after authentication. Wayland version is running fine. Not sure if the problem is related to xserver or Gnome Shell affecting hybrid laptops.

Version-Release number of selected component (if applicable):
3.16.1.

How reproducible:
Always

Steps to Reproduce:
1. After updating to 3.16.1. using hybrid laptop, attempt at login
2.
3.

Actual results:
The default session crashed with the "Oh No!" Message.

Expected results:
Login to the default session is successful and ready to use.

Additional info:

Comment 1 Alastair Neil 2015-04-22 17:45:22 UTC
Same here lenovo X320,  Gnome Wayland still works.  Not sure where to locate any trace or logs from the shell.

Comment 2 Alastair Neil 2015-04-22 17:52:15 UTC
I found that either disabling the trackpad or enabling two fingered scroll resolves this.

Comment 3 Luya Tshimbalanga 2015-04-22 18:19:32 UTC
No effect with disabled Touchpad on ASUS X550ZE.

Comment 4 Luya Tshimbalanga 2015-04-26 20:09:11 UTC
Update the title as the bug may affect hybrid laptops.

Comment 5 Fedora Blocker Bugs Application 2015-04-28 22:13:18 UTC
Proposed as a Blocker for 22-alpha by Fedora user luya using the blocker tracking app because:

 Recent update from gnome-shell to 3.16.1 broke the X session resulting the "Oh No! Something went wrong" message. I can only use Gnome on Wayland running on known issue like drap and drop, clipboard. Not sure if issue affects hybrid laptop or it is a driver problem.

Comment 6 DO NOT USE account not monitored (old adamwill) 2015-04-28 22:20:11 UTC
We need the journal rather than dmesg, thanks.

There's no point nominating the bug as an Alpha blocker as Alpha shipped already, you can't block something we already released. :P Changing the nomination to Final.

Comment 7 Luya Tshimbalanga 2015-04-28 22:55:25 UTC
(In reply to Adam Williamson (Fedora) from comment #6)
> We need the journal rather than dmesg, thanks.
> 
> There's no point nominating the bug as an Alpha blocker as Alpha shipped
> already, you can't block something we already released. :P Changing the
> nomination to Final.

Thanks for changing it. I realized too late the blocker was set to Alpha.

Comment 8 Luya Tshimbalanga 2015-04-28 23:02:07 UTC
Created attachment 1019909 [details]
Relevant journal report with backtrace

Journal file as requested

Comment 9 drago01 2015-04-29 14:13:06 UTC
(In reply to Luya Tshimbalanga from comment #8)
> Created attachment 1019909 [details]
> Relevant journal report with backtrace
> 
> Journal file as requested

That log does not contain anything from gnome-session or Xorg ... can you place attach a more complete one?

Comment 10 Luya Tshimbalanga 2015-04-29 15:18:02 UTC
Created attachment 1020225 [details]
journal -r | grep gnome

Comment 11 Luya Tshimbalanga 2015-04-29 15:19:45 UTC
Created attachment 1020227 [details]
Xorg log

Comment 12 Luya Tshimbalanga 2015-05-01 08:13:06 UTC
I managed to successfully run Gnome X Session by renaming dconf folder inside .config. That still does not explain why gnome-shell session works fine on wayland.
Manually doing such fix would be a bad experience for users upgrading from say Fedora 21 so a proper mechanism should be done automatically.

Folder in dconf contained
user  user.8I75NX  user.QT02VX  user.XQ7N2W

I don't know what user.xxxx is for, they seem a culprit for crashing X session.

Comment 13 drago01 2015-05-01 08:56:38 UTC
Apr 29 08:07:11 muamba-telus1603 gnome-session[8389]: gnome-session[8389]: WARNING: App 'gnome-shell.desktop' exited with code 1
Apr 29 08:07:11 muamba-telus1603 gnome-session[8389]: Current serial number in output stream:  264
Apr 29 08:07:11 muamba-telus1603 gnome-session[8389]: Serial number of failed request:  263
Apr 29 08:07:11 muamba-telus1603 gnome-session[8389]: Value in failed request:  0x115
Apr 29 08:07:11 muamba-telus1603 gnome-session[8389]: Minor opcode of failed request:  57 ()
Apr 29 08:07:11 muamba-telus1603 gnome-session[8389]: Major opcode of failed request:  131 (XInputExtension)
Apr 29 08:07:11 muamba-telus1603 gnome-session[8389]: X Error of failed request:  BadValue (integer parameter out of range for operation)

Looking at the code:

static void
meta_input_settings_x11_set_scroll_button (MetaInputSettings  *settings,
                                           ClutterInputDevice *device,
                                           guint               button)
{
  change_property (device, "libinput Scroll Method Enabled",
                   XA_INTEGER, 32, &button, 1);
}

We we want to set the button but we set the scroll method instead ... 

But this seems already fixed in https://git.gnome.org/browse/mutter/commit/?h=gnome-3-16&id=c99da71e96513b65744bfa75e3bae71afe42f3a7 ... which missed 3.16.1 ...

I have submitted a build with the fix: http://koji.fedoraproject.org/koji/taskinfo?taskID=9615374 can you please test it once it finishes? (Will file an update later).

Comment 14 Fedora Update System 2015-05-01 10:10:12 UTC
mutter-3.16.1.1-3.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/mutter-3.16.1.1-3.fc22

Comment 15 Fedora Update System 2015-05-02 18:07:04 UTC
Package mutter-3.16.1.1-3.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing mutter-3.16.1.1-3.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-7417/mutter-3.16.1.1-3.fc22
then log in and leave karma (feedback).

Comment 16 Fedora Update System 2015-05-04 15:26:49 UTC
mutter-3.16.1.1-3.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.