Bug 1214531

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
ASL.

[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
Right, please consider removing. Actually the whole %install section can be replaced with:

install -Dm0755 withlock %{buildroot}%{_bindir}/withlock

[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
Patch is Fedora-specific.

[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: withlock-0.3-1.fc23.noarch.rpm
          withlock-0.3-1.fc23.src.rpm
withlock.noarch: W: spelling-error %description -l en_US cron -> corn, con, crone
withlock.noarch: W: spelling-error %description -l en_US hearted -> heated, earthed, hearten
withlock.noarch: W: no-documentation
withlock.noarch: W: no-manual-page-for-binary withlock
withlock.src: W: spelling-error %description -l en_US cron -> corn, con, crone
withlock.src: W: spelling-error %description -l en_US hearted -> heated, earthed, hearten
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

Rpmlint (installed packages)
----------------------------
withlock.noarch: W: spelling-error %description -l en_US cron -> corn, con, crone
withlock.noarch: W: spelling-error %description -l en_US hearted -> heated, earthed, hearten
withlock.noarch: W: no-documentation
withlock.noarch: W: no-manual-page-for-binary withlock
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

All OK.

Requires
--------
withlock (rpmlib, GLIBC filtered):
    /usr/bin/env
    python2

/usr/bin/withlock could be changed to use %{__python2} instead, to always get the system python, if you're going to the effort of fixing the header.

Package is APPROVED.

Friendly ping, in case you forgot about this.

sorry, didn't forget, but I went on vacation and now in catch-up mode - thanks for the review, I will get to your notes and importing the package soon :)

New Package SCM Request
=======================
Package Name: withlock
Short Description: Locking wrapper script
Upstream URL: https://code.google.com/p/withlock/
Owners: adamwill
Branches: f21 f22 el6 epel7
InitialCC:

Git done (by process-git-requests).

OK, changing the status so this does not clutter up my search results.

d'oh, I really thought I built this. doing it now.

OK, Rawhide build is done, builds for other releases going through now, update will be submitted after that. Thanks for the review!