Bug 1215166

Summary: missing quotes in ifup
Product: Red Hat Enterprise Linux 6 Reporter: Lukáš Nykrýn <lnykryn>
Component: initscriptsAssignee: Lukáš Nykrýn <lnykryn>
Status: CLOSED ERRATA QA Contact: Leos Pol <lpol>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.7CC: lpol, psklenar
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: initscripts-9.03.50-1.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-05-11 01:05:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1270825    

Description Lukáš Nykrýn 2015-04-24 13:31:33 UTC
From the shellcheck:

In ifup line 74:
if [ "${VLAN}" = "yes" ] && [ "$ISALIAS" = "no" ] && [ -n $DEVICE ]; then
                                                          ^-- SC2070: Always true because you failed to quote. Use [[ ]] instead.

Comment 4 Leos Pol 2016-04-04 21:04:55 UTC
Quotes are present in the initscripts-9.03.51-1.el6, but from code review, it's very insignificant change.

Comment 6 errata-xmlrpc 2016-05-11 01:05:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-0951.html