Bug 1215198

Summary:	pcsd: GUI ignores timeout value in fence_xvm agent form
Product:	Red Hat Enterprise Linux 7	Reporter:	Radek Steiger <rsteiger>
Component:	pcs	Assignee:	Ondrej Mular <omular>
Status:	CLOSED ERRATA	QA Contact:	cluster-qe <cluster-qe>
Severity:	unspecified	Docs Contact:
Priority:	medium
Version:	7.1	CC:	cluster-maint, tojeline
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	pcs-0.9.140-1.el7	Doc Type:	Bug Fix
Doc Text:	Cause: User tries to set fencing timeout (in optional arguments section) for fence_xvm based fencing device in pcs GUI. Consequence: Value of fencing timeout is not propagated into cluster. Fix: Fencing timeout was listed twice (also in advance arguments section). Timeout option was removed from advanced arguments. Result: Setting value of fencing timeout is propagated into the cluster.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-11-19 09:37:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Radek Steiger 2015-04-24 14:37:49 UTC

> Description of problem:

Adding a custom value for fencing timeout in fence_xvm form (optional arguments section) doesn't propagate it into the cluster cib.

The json dump in pcsd.log shows the _res_paramempty_timeout value as empty although it was filled  with a numerical value (I truncated the large lines a little):

I, [2015-04-20T15:10:24.487685 #16046]  INFO -- : Updating fence device
I, [2015-04-20T15:10:24.487983 #16046]  INFO -- : {"resource_id"=>"Fencing", "resource_type"=>"fence_xvm", "_res_param ... _action"=>"", "_res_paramempty_timeout"=>"", "_res_paramne_delay"=>"10", "_res_paramem...
I, [2015-04-20T15:10:24.488407 #16046]  INFO -- :  delay=10 pcmk_host_map=virt-041 ... pcmk_host_check=static-list
I, [2015-04-20T15:10:24.488615 #16046]  INFO -- : Running: /usr/sbin/pcs stonith update Fencing delay=10 pcmk_host_map=virt-041 ... pcmk_host_check=static-list


> Version-Release number of selected component (if applicable):

pcs-0.9.137-13.el7_1.2.x86_64


> Steps to Reproduce:

1. open a fence_xvm based fencing device form in pcs GUI
2. expand Optional Arguments
3. put an integer into 'timeout' field
4. submit

Comment 5 Tomas Jelinek 2015-05-11 10:47:18 UTC

patch in upstream:
https://github.com/feist/pcs/commit/c843c4251046eef915a9f91173fe0724e5bf3cbe

Comment 6 Tomas Jelinek 2015-06-05 08:05:09 UTC

Before Fix:
[root@rh71-node1 ~]# rpm -q pcs
pcs-0.9.137-13.el7_1.2.x86_64

1. open a fence_xvm based fencing device form in pcs GUI
2. expand Optional Arguments
3. put an integer into 'timeout' field
4. submit
5. page reloads
6. expand Optional Arguments
7. the value is missing in the 'timeout' field



After Fix:
[root@rh71-node1:~]# rpm -q pcs
pcs-0.9.140-1.el7.x86_64

7. The value is present in the 'timeout' field.

Comment 10 errata-xmlrpc 2015-11-19 09:37:04 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-2290.html