Bug 1215342
| Summary: | Review Request: compat-libcdio-paranoia1 - Compat package with libcdio-paranoia libraries | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kalev Lember <kalevlember> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-04-28 15:22:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Kalev Lember
2015-04-25 16:17:21 UTC
For reference, here's the diff to the F21 libcdio-paranoia package: http://paste.fedoraproject.org/215478/ I'd like to keep the diff to the original package down to the minimum in order to be able to easily share fixes when needed, so if possible please don't pick on the indentation and things like that that are also present in the original F21 package. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=9567725 Package looks fine at first blush. One basic question before going any futher: are there any special guidelines for compat packages? A quick google search only turns up an old post from Toshio [1]. [1] https://lists.fedoraproject.org/pipermail/packaging/2009-August/006431.html fedora-review has nothing interesting to say, I'll not paste the full output here, except for rpmlint.
Rpmlint
-------
Checking: compat-libcdio-paranoia1-10.2+0.90+1-1.fc23.x86_64.rpm
compat-libcdio-paranoia1-10.2+0.90+1-1.fc23.src.rpm
compat-libcdio-paranoia1.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
Requires
--------
compat-libcdio-paranoia1 (rpmlib, GLIBC filtered):
/sbin/ldconfig
libc.so.6()(64bit)
libcdio.so.16()(64bit)
libcdio.so.16(CDIO_16)(64bit)
libcdio_cdda.so.1()(64bit)
libcdio_cdda.so.1(CDIO_CDDA_1)(64bit)
libm.so.6()(64bit)
rtld(GNU_HASH)
Provides
--------
compat-libcdio-paranoia1:
compat-libcdio-paranoia1
compat-libcdio-paranoia1(x86-64)
libcdio_cdda.so.1()(64bit)
libcdio_cdda.so.1(CDIO_CDDA_1)(64bit)
libcdio_paranoia.so.1()(64bit)
libcdio_paranoia.so.1(CDIO_PARANOIA_1)(64bit)
Thanks Zbigniew!
I don't know of any explicitly written down guidelines and Toshio's post is probably the best we have.
The rule of thumb that I've always tried to follow is to use the compat- prefix when I need ABI compatibility, but don't want newly built programs to be able to link with the old ABI. This is the case here.
If I'd additionally want API compatibility and to be able to link against the library, then I wouldn't use compat- and would go with a regular parallel installable libfoo1{,-devel}, libfoo2{,-devel} naming scheme instead.
Yeah, I don't see anything else on this subject in the guidelines. Package builds fine and seems to provide the old .so version correctly. Let's hope we don't need it for too long. Package is APPROVED. Thanks! New Package SCM Request ======================= Package Name: compat-libcdio-paranoia1 Short Description: Compat package with libcdio-paranoia libraries Upstream URL: http://www.gnu.org/software/libcdio/ Owners: kalev Branches: f22 InitialCC: Git done (by process-git-requests). Package imported and built. |