Bug 1215414
| Summary: | Review Request: angelscript - Flexible cross-platform scripting library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Igor Gnatenko <ignatenko> |
| Component: | Package Review | Assignee: | Hans de Goede <hdegoede> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dan, gwync, hdegoede, package-review, pahan |
| Target Milestone: | --- | Flags: | hdegoede:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | angelscript-2.30.0-6.fc22 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-07-30 00:59:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 879931 | ||
| Bug Blocks: | 879928, 1208136 | ||
|
Description
Igor Gnatenko
2015-04-26 12:52:46 UTC
ldconfig: Can't link /lib64//usr/local/lib/libangelscript.so to libangelscript.so.2.30.0 Don't have idea how to fix this When do you get that error? > Name: angelscript > %prep > %setup -q -n sdk This is not nice, since "-n sdk" implies "rm -rf sdk" in builddir root and may wipe something in a completely unexpected way. Typically, in such a case where %name is completely different from top source dir, you would use %setup -c and "cd sdk" in %prep, %build and %install: I don't get that error either. I expected it at install time but I got nothing. Is it at compile time for another program, like stk or something? Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/angelscript.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/angelscript-2.30.0-2.fc23.src.rpm I've fixed all issues I think. *** Bug 879931 has been marked as a duplicate of this bug. *** I'm going to review this one, assigning it to myself. (In reply to Hans de Goede from comment #6) > I'm going to review this one, assigning it to myself. I'm happy %) Let's do it! Full review done: Good: -------- - rpmlint checks return: angelscript-devel.x86_64: W: only-non-binary-in-usr-lib 4 packages and 0 specfiles checked; 0 errors, 1 warnings. This warning can be ignored - package meets naming guidelines - package meets packaging guidelines - license (zlib) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Should fix: -Change the %doc for -devel from "%doc sdk/docs/*" to "%doc sdk/docs/manual/*" to avoid including the files under dk/docs/articles in both the main package and the -devel package No blockers: Approved. > -Change the %doc for -devel from "%doc sdk/docs/*" to "%doc sdk/docs/manual/*" to avoid including the files under dk/docs/articles in both the main package and the -devel package I will fix on import stage. Thanks for review! New Package SCM Request ======================= Package Name: angelscript Short Description: Flexible cross-platform scripting library Upstream URL: http://www.angelcode.com/angelscript/ Owners: ignatenkobrain Branches: f21 f22 Git done (by process-git-requests). angelscript-2.30.0-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/angelscript-2.30.0-3.fc22 *** Bug 879931 has been marked as a duplicate of this bug. *** angelscript-2.30.0-3.fc22 has been pushed to the Fedora 22 testing repository. angelscript-2.30.0-6.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/angelscript-2.30.0-6.fc22 two notes - it fails to build on all secondary arches, please either fix it or make it ExclusiveArch - there seem to be some assembler code in source/as_callfunc_x64_gcc.cpp that's being used for non-x86 arches - there are tons of "dereferencing type-punned pointer will break strict-aliasing rules" warnings, please build with --fno-strict-aliasing, ignoring them can lead to unpredictable results especially in combination with gcc5 (In reply to Dan Horák from comment #15) > two notes > - it fails to build on all secondary arches, please either fix it or make it > ExclusiveArch - there seem to be some assembler code in > source/as_callfunc_x64_gcc.cpp that's being used for non-x86 arches I will do now exclusivearch and try to fix in the future if someone will need for secondary arches > - there are tons of "dereferencing type-punned pointer will break > strict-aliasing rules" warnings, please build with --fno-strict-aliasing, > ignoring them can lead to unpredictable results especially in combination > with gcc5 Will do angelscript-2.30.0-6.fc22 has been pushed to the Fedora 22 stable repository. |