Bug 1215727
Summary: | Whenever an exception is thrown in the front end code, unrelated parts of the GUI tend to stop working (e.g. 'new' and 'import' buttons under Networks tab) | |||
---|---|---|---|---|
Product: | [oVirt] ovirt-engine | Reporter: | Michael Burman <mburman> | |
Component: | Frontend.WebAdmin | Assignee: | Vojtech Szocs <vszocs> | |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Pavel Novotny <pnovotny> | |
Severity: | medium | Docs Contact: | ||
Priority: | unspecified | |||
Version: | --- | CC: | bugs, gklein, lsurette, mgoldboi, rbalakri, sbonazzo, srevivo, ykaul | |
Target Milestone: | ovirt-4.0.0-alpha | Keywords: | ZStream | |
Target Release: | 4.0.0 | Flags: | rule-engine:
ovirt-4.0.0+
rule-engine: planning_ack+ ecohen: devel_ack+ pstehlik: testing_ack+ |
|
Hardware: | x86_64 | |||
OS: | Linux | |||
Whiteboard: | ||||
Fixed In Version: | ovirt 4.0.0 alpha1 | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 1275760 (view as bug list) | Environment: | ||
Last Closed: | 2016-07-05 07:52:42 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | UX | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 1275760 |
Description
Michael Burman
2015-04-27 14:38:04 UTC
kind of a duplicate of bug 1049409, I think. ovirt-3.6.0-3 release Please note, this bug is still exist on 3.6.0-0.12.master.el6 Same behavior..with the same steps.. This bug is still exist on 3.6.0-0.13.master.el6 same behavior with the same steps. Unfortunately, adding global uncaught exception handler doesn't solve the problem of the GUI left in "broken" state after a runtime exception occurs (and prevents subsequent code from being executed). I'd suggest to implement a GUI dialog that informs the user of a runtime exception along with: - suggestion to reload the web page - pointing to client-side logs that can be used to report the problem Fixing this in code is not easy as it would involve heavy defensive programming (null checks and/or try-catch blocks, etc.) applied to existing code (refactoring). @Einav, what do you think? After talking with Einav, we might want to notify the user of a runtime exception via PatternFly/Bootstrap alert box, shown in the top center part of the GUI: https://www.patternfly.org/widgets/#alerts (In reply to vszocs from comment #6) > After talking with Einav, we might want to notify the user of a runtime > exception via PatternFly/Bootstrap alert box, shown in the top center part > of the GUI: > > https://www.patternfly.org/widgets/#alerts indeed - thanks, Vojtech - sorry for not updating the BZ myself :) Note that global alert messages (as mentioned in comment #6) are currently available in WebAdmin only. Removing link to patch "Enable contextual alerts in UserPortal" as this BZ is already ON_QA. Sorry for the noise. (In reply to vszocs from comment #8) > Note that global alert messages (as mentioned in comment #6) are currently > available in WebAdmin only. moving BZ back to POST - let's use this BZ to track the user portal change as well. Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release. [BTW, not sure why BZ was moved to ON_QA on 2015-10-15 - relevant patches were not included in any recently-released 3.6 build] Vojtech: once patch for user portal is merged, please move to MODIFIED. Afterwards, I will clone the BZ for ovirt-3.6.z, and you will be able to backport the patch in the context of the cloned BZ. Verified in rhevm-4.0.0.6-0.1.el7ev.noarch (build 4.0.0-19). ovirt-engine-webadmin-portal-4.0.0.6-0.1.el7ev.noarch Verified according to reproducer in comment 0. UI exception display is enabled: # engine-config -g DisplayUncaughtUIExceptionsDisplayUncaughtUIExceptions: true version: general Closing the Networks -> Import dialog via Close button or 'X' works. No UI exception is thrown. The GUI is still operational, menu buttons New / Import / Edit/ Remove also work as expected. oVirt 4.0.0 has been released, closing current release. |