Bug 1216097

Summary: pmdabash does not accept socket-related options during installation
Product: Red Hat Enterprise Linux 7 Reporter: Miloš Prchlík <mprchlik>
Component: pcpAssignee: Nathan Scott <nathans>
Status: CLOSED ERRATA QA Contact: Michal Kolar <mkolar>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.1CC: brolley, fche, lberk, mbenitez, mcermak, mgoodwin, mkolar, nathans
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-01 18:29:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Miloš Prchlík 2015-04-28 13:32:08 UTC
Description of problem:


I thought about experimenting with pmdabash & network (because pipe does not seem to work correctly, https://bugzilla.redhat.com/show_bug.cgi?id=1216085), so using socket instead of pipe:


[root@ibm-z10-06 bash]# ./Install 
You will need to choose an appropriate configuration for installation of
the "bash" Performance Metrics Domain Agent (PMDA).

  collector     collect performance statistics on this system
  monitor       allow this system to monitor local and/or remote systems
  both          collector and monitor configuration for this system

Please enter c(ollector) or m(onitor) or b(oth) [b] 
Install bash as a daemon or dso agent? [daemon] 
PMCD should communicate with the bash daemon via a pipe or a socket? [pipe] socket
Use Internet, IPv6 or Unix domain sockets? [Internet] 
Internet port number or service name? [2082] 
Updating the Performance Metrics Name Space (PMNS) ...
Terminate PMDA if already installed ...
Updating the PMCD control file, and notifying PMCD ...
Check bash metrics have appeared ... 10 warnings, 10 metrics and 0 values
[root@ibm-z10-06 bash]# 
[root@ibm-z10-06 bash]# 
[root@ibm-z10-06 bash]# 
[root@ibm-z10-06 bash]# pminfo -f bash
bash.xtrace.numclients: pmLookupDesc: No PMCD agent for domain of request
bash.xtrace.maxmem: pmLookupDesc: No PMCD agent for domain of request
bash.xtrace.queuemem: pmLookupDesc: No PMCD agent for domain of request
bash.xtrace.count: pmLookupDesc: No PMCD agent for domain of request
bash.xtrace.records: pmLookupDesc: No PMCD agent for domain of request
bash.xtrace.parameters.pid: pmLookupDesc: No PMCD agent for domain of request
bash.xtrace.parameters.parent: pmLookupDesc: No PMCD agent for domain of request
bash.xtrace.parameters.lineno: pmLookupDesc: No PMCD agent for domain of request
bash.xtrace.parameters.function: pmLookupDesc: No PMCD agent for domain of request
bash.xtrace.parameters.command: pmLookupDesc: No PMCD agent for domain of request
[root@ibm-z10-06 bash]# 
[root@ibm-z10-06 bash]# 
[root@ibm-z10-06 bash]# 


Specific command line used to start pmdabash was "/var/lib/pcp/pmdas/bash/pmdabash.orig -d 112 -i 2082", however "-i" option is not supported by pmdabash, as documented by stracing pmdabash:

53549      0.000026 write(0, "pmdabash.orig: invalid option -- 'i'\nUsage: pmdabash.orig [options]\n\nOptions:\n  -d NUM, --domain=NUM  use domain (numeric) for metrics domain of PMDA\n  -l FILE, --log=FILE   write log to FILE rather than using default log name\n  -m SIZE, --memory=SIZE\n                        maximum memory used per logfile (default 2MB)\n  -s DELTA, --interval=DELTA\n                        default delay between iterations (default 1 sec)\n  -U USER, --username=USER\n                        run the PMDA using the named user account\n  -?, --help            show this usage message and exit\n", 574) = 574


Version-Release number of selected component (if applicable):

pcp-3.9.10-8
This is also true for RHEL6.7 build, pcp-3.10.3-2, though bash version included in RHEL6.7 is not supported by pmcdbash (4.1.2-33 is too low), therefore I'm focusing mostly on RHEL7.


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Miloš Prchlík 2015-04-28 13:45:32 UTC
Since I also checked other socket variants (IPv6, unix) this bug should probably include all three of them. In all cases pmdabash fails to start, complaining about options:

Inet: ["/var/lib/pcp/pmdas/bash/pmdabash.orig", "-d", "112", "-i", "2082"]
Unix: ["/var/lib/pcp/pmdas/bash/pmdabash.orig", "-d", "112", "-u", "/tmp/pmdabash.sock"]
IPv6: ["/var/lib/pcp/pmdas/bash/pmdabash.orig", "-d", "112", "-6", "2082"]

This options are not mentioned in manual page or pmdabash's --help.

Comment 6 Nathan Scott 2016-05-11 03:18:26 UTC
Low priority, & has not reached top of the priority list - shifting to 7.4.

Comment 7 Nathan Scott 2016-12-13 19:30:04 UTC
Fixed by upstream commit 3d8bac742e15add.

Comment 9 Michal Kolar 2017-06-13 14:04:01 UTC
Reproduced against pcp-3.10.6-2.el7 and verified against pcp-3.11.8-5.el7.
Verified that socket option was removed from install script.

Comment 10 errata-xmlrpc 2017-08-01 18:29:33 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1968