Bug 1216157

Summary:	SCVMM provisioning - exception thrown if CPU limit and reservations are not set.
Product:	Red Hat CloudForms Management Engine	Reporter:	Bronagh Sorota <bsorota>
Component:	Provisioning	Assignee:	Bronagh Sorota <bsorota>
Status:	CLOSED ERRATA	QA Contact:	Milan Falešník <mfalesni>
Severity:	high	Docs Contact:
Priority:	high
Version:	5.4.0	CC:	dclarizi, gblomqui, jhardy, mfalesni, obarenbo
Target Milestone:	GA
Target Release:	5.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-06-16 13:00:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Bronagh Sorota 2015-04-28 15:56:54 UTC

Description of problem:
When the user provisions a new VM the CPU limit and reservation must be set otherwise an exception is thrown.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.Add a SCVMM provider
2.Go to the Infrastructure / VMs view 
3.Select Lifecycle/Provision VMs
4.Complete the provisioning workflow but keep all default values in the Hardware tab, including the empty CPU limits and reservations.


Actual results:

An error will be returned by SCVMM and written to the scvmm.log file indicating that blank values were supplied for CPU limit and reservations.


Expected results:

If the user decides not to set CPU limits and reservations we should not try to set them.


Additional info:

Comment 2 Oleg Barenboim 2015-04-28 16:56:48 UTC

https://github.com/ManageIQ/manageiq/pull/2777

Comment 3 CFME Bot 2015-04-29 15:20:57 UTC

New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/3935d58669c43b7fa46a0e94a7376f7a17e778be

commit 3935d58669c43b7fa46a0e94a7376f7a17e778be
Author:     Bronagh Sorota <bsorota>
AuthorDate: Tue Apr 28 12:23:40 2015 -0400
Commit:     Bronagh Sorota <bsorota>
CommitDate: Tue Apr 28 12:38:39 2015 -0400

    SCVMM - Handles unset CPU limits and reservations
    
    for newly provisioned VMs
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1216157

 vmdb/app/models/miq_provision_microsoft/cloning.rb |  13 ++-
 vmdb/spec/models/miq_provision_microsoft_spec.rb   | 101 ++++++++++++++-------
 2 files changed, 78 insertions(+), 36 deletions(-)

Comment 5 Milan Falešník 2015-05-12 11:36:42 UTC

Verified in 5.4.0.0.26. After provisioning without limits/reservations set, no relevant error in scvmm.log, provisioning went normally. The only errors in scvmm.log are like "Virtual Guest Services is not installed on the guest operating system" which I believe are not relevant in this case.

Comment 7 errata-xmlrpc 2015-06-16 13:00:26 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html